Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs/exit on jasmine failure rebase #757 #828

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugs/exit on jasmine failure rebase #757 #828

wants to merge 2 commits into from

Conversation

hthetiot
Copy link

@hthetiot hthetiot commented Feb 22, 2018 •
edited
Loading

via @bruun

While working on writing some new (failing) tests,
npm test continued to report success.
If you had a syntax error in the spec file that made
jasmine-node unable to parse it, it would fail silently
and continue to promises-aplus-tests.

Adding --captureExceptions makes sure it exits when
an exception is thrown.

Also bumped the jasmine-node dependency to the latest version.

cc @benjamingr @kriskowal

bruun and others added 2 commits January 22, 2016 20:34
@bruun
Make npm test fail if jasmine-node throws
3029e12 
While working on writing some new (failing) tests,
`npm test` continued to report success.
If you had a syntax error in the spec file that made
jasmine-node unable to parse it, it would fail silently
and continue to `promises-aplus-tests`.

Adding `--captureExceptions` makes sure it exits when
an exception is thrown.

Also bumped the jasmine-node dependency to the latest version.
@hthetiot
merge 3029e12 and trim whitespace on README.md
cf16159
@hthetiot hthetiot mentioned this pull request Feb 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hthetiot @bruun