Make index creation deterministic #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By ensuring randstrobes are sorted by all their fields.
|
Merging as I need this for further experiments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By ensuring randstrobes are sorted by all their fields.
I thought that the comparison function I added in #386 (commit 2e4ff95) was good enough, but now that I ran on some other datasets that I hadn’t used for testing previously, it became apparent that that’s not the case because I was getting non-reproducible results.
This slows down index creation again a little bit (now takes ~61s instead of ~60s for CHM13), but it’s still a lot faster than before parallel sorting.