Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need automatic scaling for servingruntimes based on some gpu load metric. The default deployment included metrics including prometheus. Using keda we want to scale based on prometheus queries.
The current options for scaling are
hpa
annotation. But this creates a managed hpa that only works with the buildin kubernetes metrics. Adding another hpa will conflict with the already created one.This PR adds the
external
option where the controller wont set the replicas and wont create an hpa.Modifications
The already existing External AutoscalerClass is now checked for instead of crashing the controller. The behavior is the same as
None
except it does not set the replicas property.Result
potentially/partially solves #372