[feature/remove-databinding] 데이터바인딩 삭제 + kapt 삭제 (#272)

* Remove layout file using databinding * Remove kapt plugin * Update linearprogressview api * Remove bindingadapter
ku-ring · Jul 14, 2024 · fb281ff · fb281ff
1 parent 06297eb
commit fb281ff
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 270 deletions.
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -119,7 +119,3 @@ dependencies {
     implementation(platform(libs.firebase.bom))
     implementation(libs.firebase.crashlytics.ktx)
 }
-
-kapt {
-    correctErrorTypes = true
-}
diff --git a/build-logic/src/main/kotlin/com/ku_stacks/ku_ring/buildlogic/convention/ApplicationPlugin.kt b/build-logic/src/main/kotlin/com/ku_stacks/ku_ring/buildlogic/convention/ApplicationPlugin.kt
@@ -21,7 +21,6 @@ class ApplicationPlugin : Plugin<Project> {
     override fun apply(target: Project) = with(target) {
         with(pluginManager) {
             apply("com.android.application")
-            apply("kotlin-kapt") // remove when view binding is no longer used
         }
 
         apply<KotlinPlugin>()
@@ -43,9 +42,6 @@ class ApplicationPlugin : Plugin<Project> {
                     )
                 }
             }
-            buildFeatures {
-                dataBinding = true
-            }
         }
         dependencies {
             implementation(libs.library("androidx-fragment-ktx"))

diff --git a/...gic/src/main/kotlin/com/ku_stacks/ku_ring/buildlogic/convention/ViewBasedFeaturePlugin.kt b/...gic/src/main/kotlin/com/ku_stacks/ku_ring/buildlogic/convention/ViewBasedFeaturePlugin.kt
@@ -13,19 +13,12 @@ import org.gradle.kotlin.dsl.getByType
 
 class ViewBasedFeaturePlugin : Plugin<Project> {
     override fun apply(target: Project) = with(target) {
-        with(pluginManager) {
-            apply("kotlin-kapt") // remove when view binding is no longer used
-        }
-
         apply<FeaturePlugin>()
 
         extensions.getByType<BaseExtension>().apply {
             buildFeatures.apply {
                 viewBinding = true
             }
-            dataBinding {
-                enable = true
-            }
         }
         dependencies {
             implementation(libs.library("androidx-fragment-ktx"))

diff --git a/build.gradle.kts b/build.gradle.kts
@@ -19,7 +19,6 @@ plugins {
     alias(libs.plugins.android.application) apply false
     alias(libs.plugins.android.library) apply false
     alias(libs.plugins.kotlin.android) apply false
-    alias(libs.plugins.kotlin.kapt) apply false
     alias(libs.plugins.kotlin.ksp) apply false
     alias(libs.plugins.dagger.hilt) apply false
     alias(libs.plugins.google.services) apply false

diff --git a/...designsystem/src/main/java/com/ku_stacks/ku_ring/designsystem/components/KuringWebView.kt b/...designsystem/src/main/java/com/ku_stacks/ku_ring/designsystem/components/KuringWebView.kt
@@ -33,7 +33,6 @@ import com.ku_stacks.ku_ring.designsystem.R
 import com.ku_stacks.ku_ring.designsystem.kuringtheme.KuringTheme
 import com.ku_stacks.ku_ring.designsystem.kuringtheme.values.Pretendard
 
-
 @Composable
 fun KuringWebView(
     url: String?,

diff --git a/core/ui_util/src/main/java/com/ku_stacks/ku_ring/ui_util/BindingAdapters.kt b/core/ui_util/src/main/java/com/ku_stacks/ku_ring/ui_util/BindingAdapters.kt
diff --git a/core/ui_util/src/main/java/com/ku_stacks/ku_ring/ui_util/dialogs/KuringDialog.kt b/core/ui_util/src/main/java/com/ku_stacks/ku_ring/ui_util/dialogs/KuringDialog.kt
@@ -7,8 +7,8 @@ import android.graphics.drawable.ColorDrawable
 import android.os.Bundle
 import android.view.View
 import android.widget.TextView
+import androidx.core.view.isVisible
 import com.ku_stacks.ku_ring.ui_util.R
-import com.ku_stacks.ku_ring.ui_util.visibleIf
 
 class KuringDialog(context: Context) : Dialog(context) {
 
@@ -83,7 +83,7 @@ class KuringDialog(context: Context) : Dialog(context) {
             confirmButton.text = it
         }
 
-        titleTextView.visibleIf(title != null)
-        descriptionTextView.visibleIf(description != null)
+        titleTextView.isVisible = title != null
+        descriptionTextView.isVisible = description != null
     }
 }
diff --git a/feature/edit_subscription/src/main/res/layout/activity_edit_subscription.xml b/feature/edit_subscription/src/main/res/layout/activity_edit_subscription.xml
diff --git a/feature/notice_detail/src/main/res/layout/activity_notice_web.xml b/feature/notice_detail/src/main/res/layout/activity_notice_web.xml
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -274,7 +274,6 @@ android-test = [
 android-application = { id = "com.android.application", version.ref = "android-gradle" }
 android-library = { id = "com.android.library", version.ref = "android-gradle" }
 kotlin-android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" }
-kotlin-kapt = { id = "org.jetbrains.kotlin.kapt", version.ref = "kotlin" }
 kotlin-ksp = { id = "com.google.devtools.ksp", version.ref = "ksp" }
 dagger-hilt = { id = "com.google.dagger.hilt.android", version.ref = "hilt" }
 google-services = { id = "com.google.gms.google-services", version.ref = "google-services" }