feat: 도서관 남은 좌석 UI 구현 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwy3055
requested changes
Dec 11, 2024
.../src/main/java/com/ku_stacks/ku_ring/designsystem/components/progress/CircularProgressBar.kt
Show resolved
Hide resolved
...ure/library/src/main/java/com/ku_stacks/ku_ring/library/compose/component/SeatStatusGroup.kt
Outdated
Show resolved
Hide resolved
...ure/library/src/main/java/com/ku_stacks/ku_ring/library/compose/component/SeatStatusGroup.kt
Outdated
Show resolved
Hide resolved
...ure/library/src/main/java/com/ku_stacks/ku_ring/library/compose/component/SeatStatusGroup.kt
Show resolved
Hide resolved
...ure/library/src/main/java/com/ku_stacks/ku_ring/library/compose/component/SeatStatusGroup.kt
Show resolved
Hide resolved
| .fillMaxWidth(), | ||
| onClick = onClick, | ||
| enabled = true, | ||
| blur = true |
feature/library/src/main/java/com/ku_stacks/ku_ring/library/compose/LibrarySeatScreen.kt
Show resolved
Hide resolved
...library/src/main/java/com/ku_stacks/ku_ring/library/compose/component/SeatStatusReloadFab.kt
Outdated
Show resolved
Hide resolved
...library/src/main/java/com/ku_stacks/ku_ring/library/compose/component/SeatStatusReloadFab.kt
Outdated
Show resolved
Hide resolved
l2hyunwoo
reviewed
Dec 13, 2024
Comment on lines
47
to
50
| modifier = Modifier.clickable( | ||
| indication = null, | ||
| interactionSource = interaction, | ||
| onClick = onNavigationIconClick |
There was a problem hiding this comment.
noClickable 같은데 TopBar 네비게이션 아이콘에 리플이 없어도 되려나요...?
There was a problem hiding this comment.
다른 부분들을 확인해보니까 리플이 있네요? 이건 일관성을 위해 삭제하도록 하겠습니다!
l2hyunwoo
reviewed
Dec 13, 2024
feature/library/src/main/java/com/ku_stacks/ku_ring/library/compose/LibrarySeatScreen.kt
Outdated
Show resolved
Hide resolved
…mpose/LibrarySeatScreen.kt
l2hyunwoo
reviewed
Dec 13, 2024
Comment on lines
14
to
37
| @AndroidEntryPoint | ||
| class LibrarySeatActivity : AppCompatActivity() { | ||
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
|
|
||
| setContent { | ||
| KuringTheme { | ||
| LibrarySeatScreen( | ||
| onBackButtonClick = ::finish, | ||
| onReservationButtonClick = {}, | ||
| modifier = Modifier.fillMaxSize() | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| companion object { | ||
| fun start(context: Context) { | ||
| val intent = Intent(context, LibrarySeatActivity::class.java) | ||
| context.startActivity(intent) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
enableEdgeToEdge 없어도 되나요?
ㅎㅎ 넵 |
boiledEgg-s
deleted the
feature/kuring-226_library_remaining_seats_ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kuring.atlassian.net/browse/KURING-226?atlOrigin=eyJpIjoiYTlhZWM5YjkwMzllNDk1NDgwZjY2ODRiNjc1Mzg1OTQiLCJwIjoiaiJ9
요약
도서관 남은 좌석 UI 구현
Navigator와 Manifest에 Activity 등록
화면 이동 로직 및 뷰모델, 상태관리 미구현 (해당 PR을 머지한 후 작업할 예정)
하단 영상은 프리뷰 인터렉티브 모드로 촬영
2024-12-09.1.27.12.mov
2024.12.18 수정사항
댓글로 달아주신 부분 수정했습니다!
enableEdgeToEdge추가