Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 도서관 남은 좌석 UI 로직 #403

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ class LibraryClient @Inject constructor(private val libraryService: LibraryServi
suspend fun fetchRoomSeatStatus(): LibrarySeatResponse = libraryService.fetchLibrarySeatStatus(
methodCode = LibrarySeatRequest.METHOD_CODE,
roomTypeId = LibrarySeatRequest.ROOM_TYPE_ID,
branchTypeId = LibrarySeatRequest.BRANCH_TYPE_ID,
branchGroupId = LibrarySeatRequest.BRANCH_GROUP_ID,
)
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ interface LibraryService {
suspend fun fetchLibrarySeatStatus(
@Query("smufMethodCode") methodCode: String,
@Query("roomTypeId") roomTypeId: Int,
@Query("branchTypeId") branchTypeId: Int,
@Query("branchGroupId") branchGroupId: Int,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API 스키마가 바뀌었나요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 제대로 확인을 못한거였습니다,, 실제로 통신해서 테스트를 한게 아니라 json파일을 직접 집어넣어서 테스트를 하다보니 쿼리스트링에서 틀린걸 인지하지 못했네요ㅎㅎ

): LibrarySeatResponse
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ package com.ku_stacks.ku_ring.remote.library.request
object LibrarySeatRequest {
const val METHOD_CODE: String = "PC"
const val ROOM_TYPE_ID = 4
const val BRANCH_TYPE_ID: Int = 1
const val BRANCH_GROUP_ID: Int = 1
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class LibraryServiceTest : ApiAbstract<LibraryService>() {
val response = service.fetchLibrarySeatStatus(
methodCode = "PC",
roomTypeId = 4,
branchTypeId = 1,
branchGroupId = 1,
)
mockWebServer.takeRequest()

Expand Down