kuring-227 드래그 LazyList, 카테고리 순서 DB 구현 #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
아이템을 드래그하여 옮길 수 있는 DraggableLazyColumn을 추가하였다.
l2hyunwoo
reviewed
Dec 25, 2024
| @Composable | ||
| fun rememberDragDropState(lazyListState: LazyListState, onMove: (Int, Int) -> Unit): DragDropState { | ||
| val scope = rememberCoroutineScope() | ||
| val state = remember(lazyListState) { |
There was a problem hiding this comment.
Q) 이거 onMove 변경될때에도 state 값 갱신해야하지 않을까요?
There was a problem hiding this comment.
실질적으로 onMove가 바뀔 일은 별로 없겠지만, 일단 추가하는 게 맞는 것 같아 수정했습니다.
l2hyunwoo
reviewed
Dec 25, 2024
Comment on lines
1
to
6
| package com.ku_stacks.ku_ring.designsystem.components.dragdrop | ||
|
|
||
| fun <T> MutableList<T>.move(from: Int, to: Int) { | ||
| if (from == to) return | ||
| val element = this.removeAt(from) | ||
| this.add(to, element) |
There was a problem hiding this comment.
여기에서만 쓰이는거라면 internal 붙여도 될 듯 합니다.
There was a problem hiding this comment.
여기에서만 쓰일 것 같아서 internal 붙였습니다.
l2hyunwoo
requested changes
Dec 25, 2024
|
컨플릭은 따로 보겠습니다. 근데 그냥 import 이슈네요 |
|
확실히 리드님의 코드는 다르네요,, 킹우영👑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kuring.atlassian.net/browse/KURING-227?atlOrigin=eyJpIjoiODliNjhlODc0ZGRiNDJmZTgyY2M3MTA5NzUwNzVmYzUiLCJwIjoiaiJ9
요약
카테고리 순서 변경의 첫 번째 작업으로, 드래그 가능한 리스트
DraggableLazyColumn과 카테고리 순서 DB를 구현했습니다.DraggableLazyColumn은 여기을 많이 참고했습니다. 코드를 자세히 보기는 조금 어려울 수도 있습니다. 프리뷰를 참고하여 보시면 됩니다.UserRepository에 기능 노출 순서대로 구현되어 있습니다. 매우 전형적인 흐름이므로 리뷰하시기 한결 쉬울 것 같습니다.