Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output visibility #137

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: output visibility #137

wants to merge 5 commits into from

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Jan 16, 2025

Overview

This PR restricts which output can be used by which tenant's subscription.
An output will be taken as a valid output if:

  • The output referenced in the subscriptions spec is valid, and present in the system.
  • The output is in the same namespace as the subscription.

As a consequence of this PR, the following things had to be adjusted:

  • unit-tests
  • e2e-test resources
  • documentation

For the sake of clarity and extensibility, I refactored almost entirely the route-reconciler.

@csatib02 csatib02 added the enhancement New feature or request label Jan 16, 2025
@csatib02 csatib02 requested review from pepov and OverOrion January 16, 2025 15:11
@csatib02 csatib02 self-assigned this Jan 16, 2025
@csatib02 csatib02 force-pushed the feat/output-visibility branch from 72ce843 to 34b8050 Compare January 16, 2025 15:12
Signed-off-by: Bence Csati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant