Add gateway_api::Duration type to support GEP-2257 Durations #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the-wondersmith
suggested changes
Aug 12, 2024
There was a problem hiding this comment.
As @kflynn mentioned, we were on a Slack call while he was working this so I probably should have voiced some of these nits then (apologies Flynn 😅).
In any case, it all obviously looks good. I've added a few suggestions, but absolutely none of them are like hard objections. Please feel absolutely free to accept or reject any of them as you see fit.
Signed-off-by: Flynn <[email protected]>
…tdDurations Co-authored-by: Mark S. <[email protected]> Signed-off-by: Flynn <[email protected]>
…or consistency Co-authored-by: Mark S. <[email protected]> Signed-off-by: Flynn <[email protected]>
…sing fails Co-authored-by: Mark S. <[email protected]> Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
kflynn
force-pushed
the
flynn/dev/gep2257
branch
from
6cbc73b
to
cb33b4e
Compare
shaneutt
reviewed
Aug 13, 2024
Co-authored-by: Mark S. <[email protected]> Signed-off-by: Flynn <[email protected]>
Co-authored-by: Shane Utt <[email protected]> Signed-off-by: Flynn <[email protected]>
Co-authored-by: Shane Utt <[email protected]> Signed-off-by: Flynn <[email protected]>
Co-authored-by: Shane Utt <[email protected]> Signed-off-by: Flynn <[email protected]>
Co-authored-by: Shane Utt <[email protected]> Signed-off-by: Flynn <[email protected]>
Co-authored-by: Shane Utt <[email protected]> Signed-off-by: Flynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gateway_api::Durationis a duration type where parsing and formatting obey GEP-2257. This PR adds the type, unit tests, and an example.Reviewers: reviewing commit by commit might be helpful, but unlike most of my PRs, it's really not that big a deal this time around.
(Many thanks to @shaneutt and @the-wondersmith for answering Rust questions. 😂)
Signed-off-by: Flynn [email protected]