Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build):Update Dockerfiles to use redhat ubi as base image #1348

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

rksharma95
Copy link
Collaborator

@rksharma95 rksharma95 commented Aug 7, 2023

Purpose of PR?:

This PR updates the existing Dockerfiles to use RedHat UBI as base image to build the kubearmor and kubearmor-init container images. RedHat UBI images inherits its foundation from RHEL ,it provides all the advantages associated with RHEL as well as eligible for Red Hat OpenShift certification.

Fixes #1201

Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes RedHat UBI as the Base Image for All Containerized Applications #1201
  • New feature (non-breaking change which adds functionality)
  • Breaking change (Not Applicable)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests (Not Applicable)
  • Commit has integration tests (Added CI workflow to test build images)

@rksharma95 rksharma95 force-pushed the feat-ubi-images branch 4 times, most recently from 4a0591b to b3ac47d Compare August 8, 2023 06:58
@rksharma95 rksharma95 force-pushed the feat-ubi-images branch 6 times, most recently from 1778303 to 0e70529 Compare August 23, 2023 14:09
@rksharma95
Copy link
Collaborator Author

currently we're facing some issue with bpflsm enforcer, some of the tests are skipped until we validate and fixed the issue #1385

Copy link
Member

@achrefbensaad achrefbensaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes

KubeArmor/BPF/shared.h Outdated Show resolved Hide resolved
KubeArmor/main.go Show resolved Hide resolved
Copy link
Member

@achrefbensaad achrefbensaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's create a new issue for the inline comment.

KubeArmor/main.go Show resolved Hide resolved
@daemon1024 daemon1024 merged commit 88f1632 into kubearmor:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RedHat UBI as the Base Image for All Containerized Applications
3 participants