Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved the dev docs #1824

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

improved the dev docs #1824

wants to merge 9 commits into from

Conversation

Manik2708
Copy link

Purpose of PR?:
This PR aims to improve documentation for new contributors as the old docs was deprecated
Fixes #

Does this PR introduce a breaking change? No

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

@Manik2708
Copy link
Author

@DelusionalOptimist @daemon1024 Please review this as the documentation is lagging behind!

contribution/contribution_guide.md Outdated Show resolved Hide resolved
contribution/testing_guide.md Outdated Show resolved Hide resolved
contribution/testing_operator_controller_guide.md Outdated Show resolved Hide resolved
@daemon1024
Copy link
Member

Can we fix the commit history, the PR looks mostly ready to merge. Thanks for taking your time to contribute :D

@Manik2708 Manik2708 force-pushed the dev-docs branch 4 times, most recently from 6299c2a to 3c3c89d Compare August 6, 2024 16:13
@Manik2708
Copy link
Author

I am trying to fix this but the older commits are appearing on squashing the commits which were committed after this PR. Can you please tell me how to fix this?

@Manik2708
Copy link
Author

@daemon1024

@daemon1024
Copy link
Member

Probably best to reset the branch to main and manually creating a new commit with all the required changes.

Signed-off-by: Manik2708 <[email protected]>
@daemon1024
Copy link
Member

All the previous comments are unresolved again ^^ Please redo them.

@Manik2708 Manik2708 force-pushed the dev-docs branch 2 times, most recently from 2ca40d2 to 95904c1 Compare August 6, 2024 17:03
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
contribution/testing_guide.md Outdated Show resolved Hide resolved
@Manik2708
Copy link
Author

@daemon1024 @Prateeknandle @rksharma95 Please review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants