Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base config #2

Merged
merged 11 commits into from
Dec 13, 2023
Merged

Add base config #2

merged 11 commits into from
Dec 13, 2023

Conversation

sheikh-arman
Copy link
Contributor

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@sheikh-arman
Add account and container
31c749d 
Signed-off-by: SK Ali Arman <[email protected]>
@sheikh-arman
Add security group, route table etc
6dff4cd 
Signed-off-by: SK Ali Arman <[email protected]>
@sheikh-arman
Add role assignment
9fcfb2e 
Signed-off-by: SK Ali Arman <[email protected]>
@sheikh-arman
Add cosmosdb examples
d44c151 
Signed-off-by: SK Ali Arman <[email protected]>
@sheikh-arman
Add mssql examples
c06c8f9 
Signed-off-by: SK Ali Arman <[email protected]>
@sheikh-arman
Add mssql examples
87dbf30 
Signed-off-by: SK Ali Arman <[email protected]>
@sheikh-arman
Add YAMLs for postgresql
f17d3f5 
Signed-off-by: SK Ali Arman <[email protected]>
@sheikh-arman sheikh-arman marked this pull request as ready for review December 11, 2023 08:47
Superm4n97
Superm4n97 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@Superm4n97 Superm4n97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamalsaha tamalsaha merged commit 09221aa into main Dec 13, 2023
6 of 8 checks passed
@tamalsaha tamalsaha deleted the azuredb branch December 13, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superm4n97 Superm4n97 Superm4n97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheikh-arman @Superm4n97 @tamalsaha