Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add doc: batch process node #657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add doc: batch process node #657

wants to merge 1 commit into from

Conversation

tangming1996
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:

Fixes #
add example for keadm bacth process node

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 23, 2024
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2024
@tangming1996 tangming1996 force-pushed the doc/batch-node-doc branch 2 times, most recently from 72a7399 to 70ce1e0 Compare December 23, 2024 09:53
Shelley-BaoYue
Shelley-BaoYue reviewed Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good！

docs/advanced/batch-node.md Outdated Show resolved Hide resolved
wbc6080
wbc6080 reviewed Jan 6, 2025
View reviewed changes
docs/advanced/batch-node.md

```

In this configuration, `--pre-run=./install-containerd.sh` is introduced in the join command, which is used to install the containerd container runtime before the node accesses. The `install-containerd.sh` file is in the directory corresponding to `nodes[x].copyFrom` and is uploaded from the `control node` to the `remote node`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a personal suggestion, could we add a picture or some text description to explain the concepts of remote node and control node where them appear firstly in this document, and explain the network connection relationship between them and the network connection with k8s master node . This can help developers understand these three types of nodes more easily.

docs/advanced/batch-node.md
maxRunNum: 5
```

In this configuration, `--post-run=./uninstall-containerd.sh` is introduced in the reset command, which is used to uninstall the containerd container runtime after the node is reset. The `uninstall-containerd.sh` file is in the directory corresponding to `nodes[x].copyFrom` and is uploaded from the `control node` to the `remote node`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, the remote node here is some edge nodes that need to be managed in batches, right? Can we directly use edge node for name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shelley-BaoYue Shelley-BaoYue Shelley-BaoYue left review comments

@wbc6080 wbc6080 wbc6080 left review comments

@fisherxu fisherxu Awaiting requested review from fisherxu

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tangming1996 @kubeedge-bot @wbc6080 @Shelley-BaoYue