Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arena makefile and dockerfile #1091

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

Syulin7
Copy link
Collaborator

@Syulin7 Syulin7 commented May 30, 2024

What this PR does / why we need it:
Since the vendor directory has been removed, it will cause the build of arena to fail.

@Syulin7 Syulin7 changed the title fix arena makefile and dockerfile Fix arena makefile and dockerfile May 30, 2024
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 3926187 into kubeflow:master May 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants