Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support distributed serving with vendor update #1194

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Support distributed serving with vendor update #1194

merged 1 commit into from
Nov 11, 2024

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Nov 8, 2024 •
edited
Loading

Purpose of this PR

Proposed changes:

  • Update go module vendor to make sure it can be built without internet connection
go mod tidy
go mod vendor

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

@cheyang cheyang changed the title Support distributed serving Support distributed serving with vendor update Nov 11, 2024
ChenYi015
ChenYi015 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@ChenYi015 ChenYi015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 11, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 22a3df5 into kubeflow:master Nov 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenYi015 ChenYi015 ChenYi015 approved these changes

@wsxiaozhang wsxiaozhang Awaiting requested review from wsxiaozhang

@xiaozhouX xiaozhouX Awaiting requested review from xiaozhouX

Assignees

@ChenYi015 ChenYi015

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheyang @ChenYi015