Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WG Data proposal #673

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

tarilabs
Copy link
Member

I'm following up on action item: raise WG proposal to Kubeflow per yesterday's Model Registry meeting (recording timestamp).

As discussed in KF community meeting.

Main links:

👉 I'm starting to raise a draft PR in order to "seed/bootstrap" the work in raising the request to form the WG--using a draft PR give us a branch we can collaborate on between stakeholders @andreyvelich @Tomcli @dhirajsb @rimolive

This also give us a medium we can keeps-tab-on so to report back on progress during Tuesdays' community plenary meetings, wdyt?

@thesuperzapper
Copy link
Member

I am very strongly opposed to using the name WG-Lifecycle, because that implies that the working group is related to the lifecycle of Kubeflow itself.

My proposal for the name is: WG-Data

Where "data" can mean both actual data (spark) and metadata (model registry). We can also split it up in the future, if the members who are maintaining these components diverge.

@tarilabs
Copy link
Member Author

My proposal for the name is: WG-Data

very well noted @thesuperzapper , as also marked here:
https://github.com/kubeflow/community/pull/673/files#diff-11b55409b3d27f083915bd4b910672caaf0e9550cf34d77fe76e8b6b9515023dR524

I just wanted to have a branch where to start collecting this kind of feedback in a non-sparse way and also to report back to you and the group on the progress on Tuesday meetings.

wgs.yaml Outdated Show resolved Hide resolved
@dhirajsb
Copy link

dhirajsb commented Dec 14, 2023

@thesuperzapper how about we make it more explicit WG ML Model Data?

@thesuperzapper
Copy link
Member

As it currently stands, this WG does not meet the requirement for diverse leadership given all chairs come from one company (IBM - which owns RedHat).

@dhirajsb
Copy link

@thesuperzapper Andrey is listed as a Chair, he's from Apple

@tarilabs
Copy link
Member Author

noticing only now it was not marked as Draft PR despite being my intent:

using a draft PR give us a branch we can collaborate on

my sincerest apologies.

Marked as Draft PR per original message in thead.

@rimolive
Copy link
Member

@thesuperzapper Is there a minimum number of companies to compose the chair to make the WG eligible?

@thesuperzapper
Copy link
Member

While there is no specific number requirement, the steering comity must approve the new WG (currently, @jbottum @james-jwu) in line with the community's interests. I would expect at least some concern with having 4 leads from one company and only 1 from another.

For reference, here is the lifecycle and other info about forming a working group:

Also, there are only meant to be 2-3 chairs, some other WGs have more, but in most cases, there are 2 active members and we just need to formally clean up the inactive chairs.

@thesuperzapper
Copy link
Member

Also, some of the proposed chairs are not even current Kubeflow org members, so are ineligible unless they go through that process first:

@rimolive
Copy link
Member

Thank you for the references! Those are valid points though, and I'll see how we can work on the eligibility topic as well as your concerns.

@tarilabs
Copy link
Member Author

As Ricardo noted, thanks !

Is there guidance for deputies to keep work WG ongoing during leaves, please?
The reason >3 is I was going through this point earlier today and seeing other WGs have >3 I assumed it was for that semantic.

As noted, will work out to account all the feedback received; thank you those are very helpful

@andreyvelich
Copy link
Member

Thank you for starting this @tarilabs! Let's collaborate together on this PR for the WG Charter and Name.

Please provide your suggestion on how we should name this WG that initially will have Spark Operator and Model Registry component.

A few initial suggestions if WG Lifecycle is too ambitious:

  • WG Data
  • WG ML Data
  • WG ML Lifecycle

I would expect at least some concern with having 4 leads from one company and only 1 from another.

This is valid concern @thesuperzapper. We can add folks from Spark Operator maintainers to this WG
cc @mwielgus @vara-bonthu @yuchaoran2011

@andreyvelich
Copy link
Member

cc @kubeflow/wg-training-leads
@kubeflow/wg-pipeline-leads
@kubeflow/wg-deployment-leads
@kubeflow/wg-notebooks-leads
@kubeflow/wg-manifests-leads

@bigsur0
Copy link

bigsur0 commented Dec 15, 2023

I would request "WG ML Lifecycle" if the purpose of the group is to house things in the MLOps orbit that don't have a more specific working group yet so they can "incubate". Data Preparation, Feature Store, and Model Registry being 3 examples that have been recently discussed that likely aren't big enough yet to have their own working group. I guess one key aspect here is to consider how new efforts can happen without the overhead of setting-up a new working group for each one until it is truly merited and bandwidth is available.

Is there a process that exists for refactoring a topic out of one working group to a new working group?

@jbottum
Copy link
Contributor

jbottum commented Dec 18, 2023

Kubeflow seems to be entering a new growth phase. The community needs a structure to support add-on components (Spark, Ray, Model Registry, Feature Store, etc). We want to encourage contributors and users to meet, discuss, experiment, decide, store code and produce documentation with a goal that integrations will help both Kubeflow and the add-on projects. We need to minimize overhead. We need to set expectations (of support...to/from Kubeflow and for users) especially if we are experimenting and trying to find market acceptance. Most importantly, we need active user participation, comment and leadership. I want to move this forward...I am a +1 to adding a single umbrella WG for all of these projects to get things moving. @james-jwu would you please provide your thoughts

@thesuperzapper
Copy link
Member

I think that the name WG Data will happily encompass the various categories proposed:

  • distributed processing (spark, Ray, etc.)
  • model registry (unnamed redhat proposal)
  • feature store (potentially feast)

Also, WG Data follows the convention of being a single word, like all other working group names.

I am still very against WG Lifecycle, at best it's like calling it WG Other because the whole point of Kubeflow is to map across the MLOps lifecycle, so it's just confusing.


Separately to the discussion around names, I think we should confirm that the maintainers of these various components are actually overlapping, otherwise it will make it difficult for this "mega working group" to function.

@vara-bonthu
Copy link
Contributor

+1 to @thesuperzapper

I would suggest voting for WG Data, as it seems most appropriate for the Spark Operator. This is because it is primarily used for data processing, both batch and streaming, as well as some ML processing.

@tarilabs
Copy link
Member Author

tarilabs commented Dec 19, 2023

New commit ae188fe incorporates some feedback received around:

  • put even more prominent name is provisional. Noted more recent feedback here and here seems will eventually converge into WG Data but while still draft is a chance to account for all proposals like here
  • reflected name provisional in PR title
  • reworked designated chairs

will keep posted during KF Community meeting on any further updates.

@tarilabs tarilabs changed the title WG Lifecycle proposal WG Data(name provisional) proposal Dec 19, 2023
@thesuperzapper
Copy link
Member

Just so we are clear, I think WG Data should be the name, not WG ML Data as the PR currently stands.

wgs.yaml Outdated Show resolved Hide resolved
wgs.yaml Outdated Show resolved Hide resolved
wgs.yaml Outdated Show resolved Hide resolved
wgs.yaml Outdated Show resolved Hide resolved
- name: model-registry
owners:
- https://raw.githubusercontent.com/kubeflow/model-registry/main/OWNERS
- name: spark-operator
Copy link

@franciscojavierarceo franciscojavierarceo Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: spark-operator
- name: feast
owners:
- https://raw.githubusercontent.com/feast-dev/feast/master/OWNERS
- name: spark-operator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I should not add subprojects belonging outside of github.com/kubeflow here, what is the @kubeflow/kubeflow-steering-committee view on this?

@andreyvelich
Copy link
Member

Please review the charter.
/assign @kubeflow/wg-pipeline-leads @kubeflow/wg-training-leads @kubeflow/wg-automl-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-manifests-leads @kubeflow/wg-data-leads @kubeflow/kubeflow-steering-committee

@tarilabs tarilabs changed the title WG Data(name provisional) proposal WG Data proposal Aug 13, 2024
wg-data/README.md Outdated Show resolved Hide resolved
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Aug 13, 2024

Would this working group be relevant for the minio replacement (seaweedfs) as well?

I am currently working on a PoC in Kubeflow/manifests.

as suggested.

Signed-off-by: tarilabs <[email protected]>

Co-authored-by: Francisco Javier Arceo <[email protected]>
@tarilabs
Copy link
Member Author

I've added all comments pertaining to Feast in a single commit with fa3c318, so to more easily manage that addition to this wg charter if required or by feedback from SC.

@tarilabs
Copy link
Member Author

Would this working group be relevant for the minio replacement (seaweedfs) as well?

not entirely sure, that to me is more a "storage"-related concern, while "data"-related concern expressed here are more orthogonal to the actual medium.

I am currently working on a PoC in Kubeflow/manifests.

I'm very happy however to engage in discussions, since "storage" is also a dimension we're exploring for Model Registry (bringing in OCI as first class, but potentially others with an abstraction layer). Let me know your thoughts!

@andreyvelich
Copy link
Member

Thank you for addressing the feedback @tarilabs!

Given that we still have discussion around WG governance and what projects WGs should maintain: #673 (comment), should we include Feast addition as a separate PR after followup discussion ?

From my point of view, initially we should just establish the Data WG with 2 Kubeflow components: Spark Operator and Model Registry, and after that we can update charter to include Feast and other projects that we want to maintain under this WG.

Any thoughts @franciscojavierarceo @kubeflow/kubeflow-steering-committee @tarilabs ?

@franciscojavierarceo
Copy link

franciscojavierarceo commented Aug 27, 2024

I would love for Feast to be included as I think the Data WG is a great opportunity to validate Feast's relevance and drive some urgency to closing the discussion on adding new projects, but I'll respect the outcome either way, of course.

See PR here: #741

CC @jbottum

@andreyvelich
Copy link
Member

I would love for Feast to be included as I think the Data WG is a great opportunity to validate Feast's relevance and drive some urgency to closing the discussion on adding new projects

I agree with you @franciscojavierarceo, but should we include Feast in the Data WG once we make Feast as part of Kubeflow core components ?

@jbottum
Copy link
Contributor

jbottum commented Aug 27, 2024

Per my comment in the Community meeting, I support Feast as part of the WG Data and as a core KF component. I am glad to pursue that path or another, if that cannot be accomplished (as I believe a defined relationship would help both communities).

@franciscojavierarceo
Copy link

@andreyvelich I am okay including Feast before making it a core component. :)

@juliusvonkohout
Copy link
Member

I'm very happy however to engage in discussions, since "storage" is also a dimension we're exploring for Model Registry (bringing in OCI as first class, but potentially others with an abstraction layer). Let me know your thoughts!

Then kubeflow/manifests#2826 and kubeflow/pipelines#10998 might be interesting for you.

@andreyvelich
Copy link
Member

Would this working group be relevant for the minio replacement (seaweedfs) as well?

I am currently working on a PoC in Kubeflow/manifests.

@juliusvonkohout This issue is related to Kubeflow Pipelines (e.g. Pipelines WG), isn't ?

@juliusvonkohout
Copy link
Member

Would this working group be relevant for the minio replacement (seaweedfs) as well?

I am currently working on a PoC in Kubeflow/manifests.

@juliusvonkohout This issue is related to Kubeflow Pipelines (e.g. Pipelines WG), isn't ?

Anyone who needs S3 storage in Kubeflow, but especially pipelines.

@rimolive
Copy link
Member

rimolive commented Oct 9, 2024

Bumping this PR. What is missing to get this merged?

@andreyvelich
Copy link
Member

Bumping this PR. What is missing to get this merged?

I think, we need to make a decision with Feast.
@kubeflow/kubeflow-steering-committee What are your thoughts on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.