-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add droctothorpe as member #657
Conversation
Hi @droctothorpe. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks again for all of your great contributions @droctothorpe 🎉
/assign @james-jwu @zijianjoy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
@droctothorpe Please sign your commit for DCO. |
9c11341
to
789dc1d
Compare
Signed-off-by: droctothorpe <[email protected]>
789dc1d
to
99eacfc
Compare
Thanks, @andreyvelich. Fixed! 👍 |
Great, thanks @droctothorpe! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, droctothorpe, james-jwu, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed this issue in favor of this PR. There are some conflicting instructions on the website vs the readme here / community repo.
Please provide links to PRs or other contributions (2-3):
** Please list 2 existing members who are sponsoring your membership:**
@connor-mccarthy
@andreyvelich
** Please test your PR **
Run
Include the output in the PR