Merge branch 'master' into add-seaweedfs-to-contrib

kubeflow · Sep 3, 2024 · 0ac99d3 · 0ac99d3
2 parents 1c923ec + da0255f
commit 0ac99d3
Show file tree

Hide file tree

Showing 179 changed files with 2,098 additions and 1,611 deletions.
diff --git a/.github/ISSUE_TEMPLATE/issue-report.yml b/.github/ISSUE_TEMPLATE/issue-report.yml
@@ -1,64 +1,67 @@
 name: Issue Report
 description: Report an Issue
 body:
-  - type: markdown
-    attributes:
-      value: |
-        Hello, Please fill out the sections below to help everyone identify and fix the bug
-  - type: checkboxes
-    id: Vaildation
-    attributes:
-      label: Validation Checklist
-      options:
-        - label: Is this a Kubeflow issue?
-          required: true
-        - label: Are you posting in the right repository ?
-          required: true
-        - label: Did you follow the installation guide https://github.com/kubeflow/manifests?tab=readme-ov-file ?
-          required: true
-        - label: Is the issue report properly structured and detailed with version numbers?
-          required: true
-        - label: Is this for Kubeflow development ?
-          required: false
-        - label: Would you like to work on this issue?
-          required: false
-        - label: You can join the CNCF Slack and access our meetings at the [Kubeflow Community](https://www.kubeflow.org/docs/about/community/) website. Our channel on the CNCF Slack is here [**#kubeflow-platform**](https://app.slack.com/client/T08PSQ7BQ/C073W572LA2).
-          required: false
-  - type: dropdown
-    id: version
-    attributes:
-      label: Version
-      description: What version of our software are you running?
-      options:
-        - master
-        - 1.9
-        - 1.8
-    validations:
+- type: markdown
+  attributes:
+    value: |
+      Fill out the sections below to help everyone identify and fix the bug
+- type: markdown
+  attributes:
+    value: |
+      Follow the [Kubeflow installation guidelines](https://github.com/kubeflow/manifests/blob/master/README.md).
+- type: checkboxes
+  id: Vaildation
+  attributes:
+    label: Validation Checklist
+    options:
+    - label: Is this a Kubeflow issue?
       required: true
-  - type: textarea
-    id: description
-    attributes:
-      label: Describe your issue
-      placeholder: When installing Kubeflow I got the following error message from ... 
-    validations:
+    - label: Are you posting in the right repository ?
       required: true
-  - type: textarea
-    id: steps
-    attributes:
-      label: Steps to reproduce the issue
-      placeholder: |
-        1. Try this ...
-        2. Then do this ...
-    validations:
+    - label: Did you follow the [Kubeflow installation guideline](https://github.com/kubeflow/manifests/blob/master/README.md) ?
       required: true
-  - type: textarea
-    id: screenshots
-    attributes:
-      label: Put here any screenshots or videos (optional)
-  - type: markdown
-    attributes:
-      value: |
-        > **Note:** Please note that you have to fill required fields to post an Issue.
-          If not please close or redo the issue and you can join the CNCF Slack and access our meetings at the [Kubeflow Community](https://www.kubeflow.org/docs/about/community/) website.  Our channel on the CNCF Slack is here [**#kubeflow-platform**](https://app.slack.com/client/T08PSQ7BQ/C073W572LA2). 
+    - label: Is the issue report properly structured and detailed with version numbers?
+      required: true
+    - label: Is this for Kubeflow development ?
+      required: false
+    - label: Would you like to work on this issue?
+      required: false
+    - label: You can join the CNCF Slack and access our meetings at the [Kubeflow Community](https://www.kubeflow.org/docs/about/community/) website. Our channel on the CNCF Slack is here [**#kubeflow-platform**](https://app.slack.com/client/T08PSQ7BQ/C073W572LA2).
+      required: false
+- type: dropdown
+  id: version
+  attributes:
+    label: Version
+    description: Which version of the Kubeflow platform are you using?
+    options:
+    - master
+    - 1.9
+  validations:
+    required: true
+- type: textarea
+  id: description
+  attributes:
+    label: Describe your issue
+    placeholder: When installing Kubeflow I got the following error message from ...
+  validations:
+    required: true
+- type: textarea
+  id: steps
+  attributes:
+    label: Steps to reproduce the issue
+    placeholder: |
+      1. Try this ...
+      2. Then do this ...
+  validations:
+    required: true
+- type: textarea
+  id: screenshots
+  attributes:
+    label: Put here any screenshots or videos (optional)
+- type: markdown
+  attributes:
+    value: |
+      > **Note:** Please note that you have to fill required fields to post an issue.
+        If not please close or redo the issue and you can join the CNCF slack and access our meetings at the [Kubeflow Community](https://www.kubeflow.org/docs/about/community/) website.  Our channel on the CNCF Slack is here [**#kubeflow-platform**](https://app.slack.com/client/T08PSQ7BQ/C073W572LA2).
 
-        **Thanks for reporting this issue! We will get back to you as soon as possible.** 
+      **Thanks for reporting this issue! We will get back to you as soon as possible.**
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -11,8 +11,7 @@
 
 ## ✅ Contributor checklist
   - Make sure you have tested with kustomize. See [Installation Prerequisites](https://github.com/kubeflow/manifests#prerequisites)
-  - All the commits have been _signed-off_  (To pass the `DCO` check)
-  - Submit the [Contributor License Agreements](https://cla.developers.google.com/clas) (To pass the `cla/google` check)
+  - All the commits have been [_signed-off_](https://github.com/kubeflow/community/tree/master/dco-signoff-hook#signing-off-commits)  (To pass the `DCO` check)
 
 ---     
 

diff --git a/.github/workflows/admission_webhook_test.yaml b/.github/workflows/admission_webhook_test.yaml
@@ -2,14 +2,12 @@ name: Build & Apply PodDefaults manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/admission_webhook_test.yaml
-      - apps/admission-webhook/upstream/**
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_istio.sh
-      - tests/gh-actions/install_cert_manager.sh
-      - common/cert-manager/**
+    - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
+    - .github/workflows/admission_webhook_test.yaml
+    - apps/admission-webhook/upstream/**
+    - tests/gh-actions/install_istio.sh
+    - tests/gh-actions/install_cert_manager.sh
+    - common/cert-manager/**
 
 jobs:
   build:
@@ -18,14 +16,8 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v4
 
-    - name: Install KinD
-      run: ./tests/gh-actions/install_kind.sh
-
-    - name: Create KinD Cluster
-      run: kind create cluster --config tests/gh-actions/kind-cluster.yaml
-
-    - name: Install kustomize
-      run: ./tests/gh-actions/install_kustomize.sh
+    - name: Install KinD, Create KinD cluster and Install kustomize
+      run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
 
     - name: Install Istio
       run: ./tests/gh-actions/install_istio.sh

diff --git a/.github/workflows/bash_formatter.yaml b/.github/workflows/bash_formatter.yaml
diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml
@@ -2,13 +2,11 @@ name: Build & Apply BentoML Yatai Stack manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/bentoml_test.yaml
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_cert_manager.sh
-      - common/cert-manager/**
-      - contrib/bentoml/**
+    - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
+    - .github/workflows/bentoml_test.yaml
+    - tests/gh-actions/install_cert_manager.sh
+    - common/cert-manager/**
+    - contrib/bentoml/**
 
 jobs:
   build:
@@ -17,14 +15,8 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v4
 
-    - name: Install KinD
-      run: ./tests/gh-actions/install_kind.sh
-
-    - name: Create KinD Cluster
-      run: kind create cluster --config tests/gh-actions/kind-cluster.yaml
-
-    - name: Install kustomize
-      run: ./tests/gh-actions/install_kustomize.sh
+    - name: Install KinD, Create KinD cluster and Install kustomize
+      run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
 
     - name: Install cert-manager
       run: ./tests/gh-actions/install_cert_manager.sh

diff --git a/.github/workflows/centraldashboard_test.yaml b/.github/workflows/centraldashboard_test.yaml
@@ -2,12 +2,10 @@ name: Build & Apply CentralDashboard manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/centraldashboard_test.yaml
-      - apps/centraldashboard/upstream/**
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_istio.sh
+    - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
+    - .github/workflows/centraldashboard_test.yaml
+    - apps/centraldashboard/upstream/**
+    - tests/gh-actions/install_istio.sh
 
 jobs:
   build:
@@ -16,14 +14,8 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v4
 
-    - name: Install KinD
-      run: ./tests/gh-actions/install_kind.sh
-
-    - name: Create KinD Cluster
-      run: kind create cluster --config tests/gh-actions/kind-cluster.yaml
-
-    - name: Install kustomize
-      run: ./tests/gh-actions/install_kustomize.sh
+    - name: Install KinD, Create KinD cluster and Install kustomize
+      run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
 
     - name: Install Istio
       run: ./tests/gh-actions/install_istio.sh

diff --git a/.github/workflows/dex_test.yaml b/.github/workflows/dex_test.yaml
@@ -2,12 +2,10 @@ name: Build & Apply Dex manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/dex_test.yaml
-      - common/dex/base/**
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_istio.sh
+    - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
+    - .github/workflows/dex_test.yaml
+    - common/dex/base/**
+    - tests/gh-actions/install_istio.sh
 
 jobs:
   build:
@@ -16,20 +14,21 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v4
 
-    - name: Install KinD
-      run: ./tests/gh-actions/install_kind.sh
-
-    - name: Create KinD Cluster
-      run: kind create cluster --config tests/gh-actions/kind-cluster.yaml
-
-    - name: Install kustomize
-      run: ./tests/gh-actions/install_kustomize.sh
-
-    - name: Install Istio
-      run: ./tests/gh-actions/install_istio.sh
+    - name: Install KinD, Create KinD cluster and Install kustomize
+      run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
 
     - name: Build & Apply manifests
       run: |
-        cd common/dex
-        kustomize build overlays/istio | kubectl apply -f -
+        while ! kustomize build ./tests/gh-actions/deploy-dex-login-environment | kubectl apply -f -; do echo "Retrying to apply resources"; sleep 20; done
         kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout 180s
+
+    - name: port forward
+      run: |
+        ingress_gateway_service=$(kubectl get svc --namespace istio-system --selector="app=istio-ingressgateway" --output jsonpath='{.items[0].metadata.name}')
+        nohup kubectl port-forward --namespace istio-system svc/${ingress_gateway_service} 8080:80 &
+        while ! curl localhost:8080; do echo waiting for port-forwarding; sleep 1; done; echo port-forwarding ready
+
+    - name: test dex login
+      run: |
+        pip3 install requests
+        ./tests/gh-actions/test_dex_login.py
diff --git a/.github/workflows/jupyter_web_application_test.yaml b/.github/workflows/jupyter_web_application_test.yaml
@@ -2,12 +2,10 @@ name: Build & Apply JWA manifests in KinD
 on:
   pull_request:
     paths:
-      - .github/workflows/jupyter_web_application_test.yaml
-      - apps/jupyter/jupyter-web-app/upstream/**
-      - tests/gh-actions/kind-cluster.yaml
-      - tests/gh-actions/install_kind.sh
-      - tests/gh-actions/install_kustomize.sh
-      - tests/gh-actions/install_istio.sh
+    - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
+    - .github/workflows/jupyter_web_application_test.yaml
+    - apps/jupyter/jupyter-web-app/upstream/**
+    - tests/gh-actions/install_istio.sh
 
 jobs:
   build:
@@ -16,14 +14,8 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v4
 
-    - name: Install KinD
-      run: ./tests/gh-actions/install_kind.sh
-
-    - name: Create KinD Cluster
-      run: kind create cluster --config tests/gh-actions/kind-cluster.yaml
-
-    - name: Install kustomize
-      run: ./tests/gh-actions/install_kustomize.sh
+    - name: Install KinD, Create KinD cluster and Install kustomize
+      run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
 
     - name: Install Istio
       run: ./tests/gh-actions/install_istio.sh