Update instructions for Kustomize 5 (#2399) #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* example: Update for kustomize 5 Add the sortOptions in the kustomization.yaml to ensure we are creating MutationWebhooks before Deployments and Pods. This way we'll ensure that Pods will get Istio sidecars in a race-free way. Signed-off-by: Kimonas Sotirchos <[email protected]> * readme: Update instructions to use Kustomize 5 Update instructions to inform users to use Kustomize 5. We'll also need to do an awk command, to remove a line that ends up in the final output. That is a regression on Kustomize's side. Once a newer version of Kustomize is available with the fix we'll then remove this awk command. Signed-off-by: Kimonas Sotirchos <[email protected]> * gh-action: Update to Kustomize 5 Update the helper script to use Kustomize 5 for the tests. Signed-off-by: Kimonas Sotirchos <[email protected]> * gh-action: Use the kustomize script in gh action Update the GH Action that runs the unit test to use the same script we use in the other GH Actions for fetching kustomize. Signed-off-by: Kimonas Sotirchos <[email protected]> * Add FAQ for earlier versions of Kustomize Signed-off-by: Kimonas Sotirchos <[email protected]> --------- Signed-off-by: Kimonas Sotirchos <[email protected]>
|
Thanks! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DomFleischmann, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick #2404 to v1.7-branch