Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] test/python-aog testbench snapshot #117

Closed

Conversation

tarilabs
Copy link
Member

Analogous to #59
a testbench for openapi-codegen-generated code and showing tests are passing as expected.

Description

The testbench provide a demonstrator using OpenAPI-codegen to codegen Python client, and using the Python client to:

  • post/get RegisteredModel
  • and then, post/get ModelVersion for a RegisteredModel
  • and then, post/get ModelArtifact and DocArtifact for a ModelVersion (of a RegisteredModel)

Screenshot 2024-05-31 at 18 55 18 (2)

How Has This Been Tested?

poetry install
poetry run pytest -s -x

in the test/python-oag directory.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Marking this PR to "snapshot" the code and the test performed, since is not to be merged at this time, raising as Draft.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tarilabs. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request Jul 10, 2024
@tarilabs
Copy link
Member Author

With the MR python client rebase on REST (#152) this appears to no longer be needed, so we're going to close this.

For more information: #181
If you believe this was closed in error, feel free to reopen or submit a new record.

Thank you for contributions, we truly appreciated your commitment and everyone's direct and indirect work to rebase the MR python client on REST.

@tarilabs tarilabs closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant