build(deps): bump github.com/testcontainers/testcontainers-go from 0.26.0 to 0.29.1 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tarilabs
requested changes
Mar 8, 2024
There was a problem hiding this comment.
This update is on hold: this requires Go >= 1.20.
There is also opportunity then to change deprecated method:
diff --git a/internal/testutils/test_container_utils.go b/internal/testutils/test_container_utils.go
index 42671550..c3ee82c7 100644
--- a/internal/testutils/test_container_utils.go
+++ b/internal/testutils/test_container_utils.go
@@ -7,6 +7,7 @@ import (
"os"
"testing"
+ "github.com/docker/docker/api/types/container"
"github.com/opendatahub-io/model-registry/internal/ml_metadata/proto"
"github.com/testcontainers/testcontainers-go"
"github.com/testcontainers/testcontainers-go/wait"
@@ -82,13 +83,8 @@ func SetupMLMetadataTestContainer(t *testing.T) (*grpc.ClientConn, proto.Metadat
Env: map[string]string{
"METADATA_STORE_SERVER_CONFIG_FILE": "/tmp/shared/conn_config.pb",
},
- Mounts: testcontainers.ContainerMounts{
- testcontainers.ContainerMount{
- Source: testcontainers.GenericBindMountSource{
- HostPath: wd,
- },
- Target: "/tmp/shared",
- },
+ HostConfigModifier: func(hc *container.HostConfig) {
+ hc.Binds = []string{wd + ":/tmp/shared"}
},
WaitingFor: wait.ForLog("Server listening on"),
}bumping Go version would also "incorporate" these changes:
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/testcontainers/testcontainers-go-0.29.1
branch
from
e848b0e
to
2613a18
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/testcontainers/testcontainers-go-0.29.1
branch
from
2613a18
to
cfb9a40
Compare
Bumps [github.com/testcontainers/testcontainers-go](https://github.com/testcontainers/testcontainers-go) from 0.26.0 to 0.29.1. - [Release notes](https://github.com/testcontainers/testcontainers-go/releases) - [Commits](testcontainers/testcontainers-go@v0.26.0...v0.29.1) --- updated-dependencies: - dependency-name: github.com/testcontainers/testcontainers-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/testcontainers/testcontainers-go-0.29.1
branch
from
cfb9a40
to
aeb9a72
Compare
rkubis
pushed a commit
to rkubis/model-registry
that referenced
this pull request
Mar 26, 2024
periodic sync upstream KF to midstream ODH
|
Superseded by #57. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/testcontainers/testcontainers-go-0.29.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/testcontainers/testcontainers-go from 0.26.0 to 0.29.1.
Release notes
Sourced from github.com/testcontainers/testcontainers-go's releases.
... (truncated)
Commits
08c2385chore: use new version (v0.29.1) in modules and examples4d7a27efix: incorrect versione48323cchore: prepare for next minor development cycle ()c17ba62chore: use new version (v0.29.0) in modules and examples12f23f8generic.go: GenericContainer(): clearer error message (#2327)cfd60e9chore: confirm support for new mongo images (#2326)85361feAdd k3s WithManifest option (#1920)755bbb8chore(deps): bump google.golang.org/grpc in /modules/qdrant (#2281)ba92e0echore(deps): bump github.com/ClickHouse/clickhouse-go/v2 (#2290)245c8b0chore(deps): bump github.com/Shopify/toxiproxy/v2 in /examples/toxiproxy (#2282)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)