Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dockerhub container registry use #41

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

tarilabs
Copy link
Member

... replaces quay.io use in CI/CD/container-registry-use which was available originally through quay.io

Resolves #23

Description

Originally (before Kubeflow code "uplift") quay.io was used for Container Registry; as requested during KF community meeting, this changes to make use of dockerhub as default.

The goal as intended was to keep build infra (makefile, scripts, GHAs) design, but to adapt it to KF community request, while preserving extensibility and customization for any downstream consumer.

How Has This Been Tested?

  • dry run (don't have the psw) of make image/build
    results as expected:
docker build . -f Dockerfile -t kubeflow/model-registry:main
  • dry run (don't have the psw) of IMG_REGISTRY=quay.io make image/build
    results as expected:
docker build . -f Dockerfile -t quay.io/kubeflow/model-registry:main
  • dry run (don't have the pws) of ./scripts/build_deploy.sh
    results as expected:
Building container image..
docker build . -f Dockerfile -t kubeflow/model-registry:cfb4712
  • GHAs: this PR will be used.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

... replaces quay.io use in CI/CD/container-registry-use
which was available originally through quay.io

Signed-off-by: Matteo Mortari <[email protected]>
@rareddy
Copy link
Contributor

rareddy commented Mar 18, 2024

/approve
/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rareddy, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c9bdfc2 into kubeflow:main Mar 18, 2024
10 checks passed
rkubis pushed a commit to rkubis/model-registry that referenced this pull request Apr 8, 2024
[pull] main from kubeflow:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce image Container Registry use
2 participants