add dockerhub container registry use #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... replaces quay.io use in CI/CD/container-registry-use which was available originally through quay.io
Resolves #23
Description
Originally (before Kubeflow code "uplift") quay.io was used for Container Registry; as requested during KF community meeting, this changes to make use of dockerhub as default.
The goal as intended was to keep build infra (makefile, scripts, GHAs) design, but to adapt it to KF community request, while preserving extensibility and customization for any downstream consumer.
How Has This Been Tested?
make image/build
results as expected:
IMG_REGISTRY=quay.io make image/build
results as expected:
./scripts/build_deploy.sh
results as expected:
Merge criteria: