Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to conditionally render MUI theme #564

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Nov 15, 2024

Description

Re-applies switch to MR UI in order to conditionally toggle MUI theme on / off.
Screenshot 2024-11-15 at 10 51 56 AM
Screenshot 2024-11-15 at 10 52 52 AM

How Has This Been Tested?

Toggle switch in page masthead and verify that the MUI theme is toggled on / off based on the value of the switch.

Tests N/A, visual updates only.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alexcreasy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jenny <[email protected]>

format

Signed-off-by: Jenny <[email protected]>

fix tests

Signed-off-by: Jenny <[email protected]>

remove unused imports

Signed-off-by: Jenny <[email protected]>

fix plain button border radius and editable label padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant