-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for multi-arch i.e. s390x & pp64cle #62
Closed
Closed
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
51b0cbc
added s390x support
1475f59
Updated Makefile
modassarrana89 c6386e4
updated Dcokerfile
modassarrana89 1fef0f1
Updated deploy script
modassarrana89 33cc79a
Updated Dockerfile.cross
modassarrana89 4097678
Updated changes
modassarrana89 885f250
Added timeout for gloangci-lint
modassarrana89 06ca5ee
Update build-and-push-image.yml
modassarrana89 ecf55ea
Merge branch 'main' into s390x
modassarrana89 8f0c027
Made changes after rebasing to latest code
modassarrana89 2e51144
resolved cgo s390x compiler issue in Makefile
modassarrana89 1ae2978
Update Makefile
modassarrana89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The download of protoc is already performed as part of
make deps
which includesmake bin/protoc
, in line below 34.This was improved with #52
Kindly consider extending
scripts/install_protoc.sh
for your platforms, so we don't need this extra Docker RUN ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didn't know about the protoc change . Once it is approved , i will update my changes accordingly for protoc