Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): Implement Start restart and stop workspace actions #162

Open
wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from

Conversation

ElayAharoni
Copy link

Fixes: #146

Implemented Start, restart and stop workspace actions present in the workspace table actions kebab dropdown.
with the requested buttons and warning, from the issue description.
snapshots:

  1. start with pending updates:
    image

  2. restart without pending updates:
    image

  3. stop without pending updates:
    image

  4. stop with pending updates:
    image

  5. restart with pending updates:
    image

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ElayAharoni ElayAharoni force-pushed the add-start-stop-and-restart-actions-to-workspaces-table branch from f56e1a3 to 1ee488d Compare January 6, 2025 11:27
Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ElayAharoni , thanks for the PR. IMO, we should have one component (and its .tsx file) for each of those modals, instead of managing UI features as React states. This way each component would be isolated and could call the appropriate BFF service to execute its action. In the Workspaces.tsx, we would have only the const [isXModalOpen, setIsXModalOpen] = React.useState(false); boolean state to manage if each popup is opened or not.

This idea is similar to what Model Registry does with ModelVersionsTableRow using the ArchiveModelVersionModal modal.

@ElayAharoni ElayAharoni force-pushed the add-start-stop-and-restart-actions-to-workspaces-table branch 5 times, most recently from a44a88f to 759dd78 Compare January 8, 2025 15:32
Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
@ElayAharoni ElayAharoni force-pushed the add-start-stop-and-restart-actions-to-workspaces-table branch from 759dd78 to b57356a Compare January 9, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants