chore(sdk): remove kfp.deprecated from sdk, legacy samples, and legac…

…y tests (#11366) * chore(sdk): remove kfp.deprecated and legacy samples and tests Signed-off-by: Chen Sun <[email protected]> * chore: clean up unused imports Signed-off-by: Chen Sun <[email protected]> --------- Signed-off-by: Chen Sun <[email protected]>
kubeflow · Nov 12, 2024 · 11a8b86 · 11a8b86
1 parent 48a1340
commit 11a8b86
Show file tree

Hide file tree

Showing 359 changed files with 196 additions and 43,361 deletions.
diff --git a/.gitignore b/.gitignore
@@ -56,10 +56,6 @@ bazel-*
 # VSCode
 .vscode
 
-# test yaml
-sdk/python/tests/compiler/pipeline.yaml
-sdk/python/tests/compiler/testdata/testpackage/pipeline.yaml
-
 # Test temporary files
 _artifacts
 

diff --git a/pytest.ini b/pytest.ini
@@ -1,3 +1,2 @@
 [pytest]
-addopts = --ignore=sdk/python/kfp/deprecated --ignore=sdk/python/kfp/tests
 testpaths = sdk/python/kfp
diff --git a/samples/core/AutoML tables/AutoML Tables - Retail product stockout prediction.ipynb b/samples/core/AutoML tables/AutoML Tables - Retail product stockout prediction.ipynb
diff --git a/samples/core/XGBoost/xgboost_sample_test.py b/samples/core/XGBoost/xgboost_sample_test.py
@@ -12,13 +12,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import kfp as kfp
+from kfp.samples.test.utils import run_pipeline_func
+from kfp.samples.test.utils import TestCase
+
 from .xgboost_sample import xgboost_pipeline
-from kfp.samples.test.utils import run_pipeline_func, TestCase
 
 run_pipeline_func([
-    TestCase(
-        pipeline_func=xgboost_pipeline,
-        mode=kfp.dsl.PipelineExecutionMode.V2_ENGINE,
-    ),
+    TestCase(pipeline_func=xgboost_pipeline),
 ])
diff --git a/samples/core/caching/caching_test.py b/samples/core/caching/caching_test.py
@@ -12,13 +12,13 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import kfp as kfp
-from kfp.samples.test.utils import TestCase, relative_path, run_pipeline_func
+from kfp.samples.test.utils import relative_path
+from kfp.samples.test.utils import run_pipeline_func
+from kfp.samples.test.utils import TestCase
 
 run_pipeline_func([
     TestCase(
         pipeline_file=relative_path(__file__, 'caching.ipynb'),
-        mode=kfp.dsl.PipelineExecutionMode.V2_ENGINE,
         run_pipeline=False,
     ),
 ])
diff --git a/samples/core/condition/condition.py b/samples/core/condition/condition.py
diff --git a/samples/core/condition/condition_test.py b/samples/core/condition/condition_test.py
@@ -15,12 +15,14 @@
 from __future__ import annotations
 
 import unittest
-import kfp.deprecated as kfp
+
+from kfp.samples.test.utils import KfpTask
+from kfp.samples.test.utils import run_pipeline_func
+from kfp.samples.test.utils import TestCase
 import kfp_server_api
 from ml_metadata.proto import Execution
-from .condition import condition
+
 from .condition_v2 import condition as condition_v2
-from kfp.samples.test.utils import KfpTask, debug_verify, run_pipeline_func, TestCase
 
 
 def verify_heads(t: unittest.TestCase, run: kfp_server_api.ApiRun,
@@ -43,24 +45,12 @@ def verify_tails(t: unittest.TestCase, run: kfp_server_api.ApiRun,
 run_pipeline_func([
     TestCase(
         pipeline_func=condition_v2,
-        mode=kfp.dsl.PipelineExecutionMode.V2_ENGINE,
         arguments={"force_flip_result": "heads"},
         verify_func=verify_heads,
     ),
     TestCase(
         pipeline_func=condition_v2,
-        mode=kfp.dsl.PipelineExecutionMode.V2_ENGINE,
         arguments={"force_flip_result": "tails"},
         verify_func=verify_tails,
     ),
-    TestCase(
-        pipeline_func=condition,
-        mode=kfp.dsl.PipelineExecutionMode.V1_LEGACY,
-        arguments={"force_flip_result": "heads"},
-    ),
-    TestCase(
-        pipeline_func=condition,
-        mode=kfp.dsl.PipelineExecutionMode.V1_LEGACY,
-        arguments={"force_flip_result": "tails"},
-    ),
 ])
diff --git a/samples/core/condition/nested_condition_test.py b/samples/core/condition/nested_condition_test.py
@@ -12,13 +12,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import kfp as kfp
+from kfp.samples.test.utils import run_pipeline_func
+from kfp.samples.test.utils import TestCase
+
 from .nested_condition import my_pipeline
-from kfp.samples.test.utils import run_pipeline_func, TestCase
 
 run_pipeline_func([
-    TestCase(
-        pipeline_func=my_pipeline,
-        mode=kfp.dsl.PipelineExecutionMode.V2_ENGINE,
-    ),
+    TestCase(pipeline_func=my_pipeline),
 ])