DRAFT WIP - do not merge - demonstration of PipelineConfig

Demonstration of proposed KFP DSL PipelineConfig class. Signed-off-by: Greg Sheremeta <[email protected]>
kubeflow · Aug 17, 2024 · ba657de · ba657de
1 parent f160004
commit ba657de
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 10 deletions.
diff --git a/api/v2alpha1/go/pipelinespec/pipeline_spec.pb.go b/api/v2alpha1/go/pipelinespec/pipeline_spec.pb.go
diff --git a/api/v2alpha1/pipeline_spec.proto b/api/v2alpha1/pipeline_spec.proto
@@ -1058,5 +1058,5 @@ message PlatformDeploymentConfig {
 
 // Spec for pipeline-level config options. See PipelineConfig DSL class.
 message PipelineConfig {
-  // TODO add pipeline-level configs
+  string example_pipeline_config = 1;
 }
diff --git a/sdk/python/kfp/compiler/pipeline_spec_builder.py b/sdk/python/kfp/compiler/pipeline_spec_builder.py
@@ -1879,7 +1879,9 @@ def create_pipeline_spec(
 
     # pipeline-level config options
     pipeline_config_spec = pipeline_spec_pb2.PipelineConfig()
-    # TODO add pipeline-level config options
+    if pipeline_config.example_pipeline_config is not None and pipeline_config.example_pipeline_config != "":
+        pipeline_config_spec.example_pipeline_config = pipeline_config.example_pipeline_config
+
 
     pipeline_spec.root.CopyFrom(
         _build_component_spec_from_component_spec_structure(component_spec))

diff --git a/sdk/python/kfp/dsl/pipeline_config.py b/sdk/python/kfp/dsl/pipeline_config.py
@@ -18,7 +18,13 @@ class PipelineConfig:
     """PipelineConfig contains pipeline-level config options."""
 
     def __init__(self):
-        pass
+        self.example_pipeline_config = "some-important-value"
 
-    # TODO add pipeline level configs
+    def set_example_pipeline_config(self, example_pipeline_config: str):
+        """Example of a pipeline-level config option.
 
+        Args:
+          example_pipeline_config: example setting to set in the PipelineConfig spec
+        """
+        self.example_pipeline_config = example_pipeline_config
+        return self