-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(samples/contrib/modular_exponentiation_quantum_circuit) #10949
base: master
Are you sure you want to change the base?
Conversation
…w pipeline Signed-off-by: Rhm-B-WT <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Rhm-B-WT. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@Rhm-B-WT: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I've tested the code on kubeflow and it worked. The AttributeError said "module 'kfp_server_api' has no attribute 'ApiGetHealthzResponse'". The environment I used is python 3.11.7. How can I fix it? |
@Rhm-B-WT I'm migrating the kubeflow-pipelines-samples-v2 tests to GitHub Actions and facing this issue too. When I complete this migration the problem should be fixed. It would be nice to have a test for this new sample you're adding. However, since the existing tests are not working, we need to wait for the migration to GitHub Actions. Can we put this PR on hold in the meantime? /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rhm-B-WT now that we have tests for samples, can you please add a test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rhm-B-WT you don't need to create any scripts to run the test. You just need to add your test to
pipelines/samples/v2/sample_test.py
Line 46 in ba006bd
test_cases: List[TestCase] = [ |
Create an example of modular exponentiation quantum circuit in kubflow pipeline