test: Migrate KFP SDK Execution Tests to GHA #10975
Conversation
|
/lgtm |
.github/workflows/sdk-execution.yml
Outdated
| uses: container-tools/kind-action@v2 | ||
| with: | ||
| cluster_name: kfp | ||
| kubectl_version: v1.29.2 | ||
| version: v0.22.0 | ||
| node_image: kindest/node:v1.29.2 | ||
|
|
||
| - name: Build images | ||
| run: ./scripts/deploy/github/build-images.sh | ||
|
|
||
| - name: Deploy KFP | ||
| run: ./scripts/deploy/github/deploy-kfp.sh |
There was a problem hiding this comment.
You can use the kfp-cluster action here. Like
pipelines/.github/workflows/e2e-test.yaml
Line 27 in 7d2ec39
There was a problem hiding this comment.
Done, updated to use this action.
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: 3.8 |
There was a problem hiding this comment.
Don't we want to test with the other versions as well?
You can use a matrix for that. See https://github.com/kubeflow/pipelines/pull/10926/files#diff-e842340381d5ec7517ff5c2522b081e6b081cad5701ce9f06af7d088428974eeR17-R24
There was a problem hiding this comment.
the Prow Job used only Python 3.8: https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-presubmits.yaml#L238
Do we need this for other versions? I would suggest keeping it simple, to one version, and not adding more jobs / more time to execute tests for every PR.
There was a problem hiding this comment.
Do we need this for other versions?
I don't have a strong opinion, but testing with all supported versions would be nice.
I would suggest keeping it simple, to one version, and not adding more jobs / more time to execute tests for every PR.
The jobs run in parallel, so unless we reach the limit of parallel executions, it shouldn't increase the execution time.
@rimolive any thoughts?
There was a problem hiding this comment.
Only 4 jobs run in parallel. I just saw that on my PR.
So yeah, it would increase the execution time.
|
@DharmitD: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/rerun-all |
|
@zijianjoy Can you help us? PR is already approved but because Prow had failed tests it does not merge. If you take a look, the correspondent GHA workflow with the failed Prow test passed with no issues. |
@rimolive @zijianjoy just to complement, GoogleCloudPlatform/oss-test-infra#2313 removes the |
|
@james-jwu can you help us to get this PR and GoogleCloudPlatform/oss-test-infra#2313 merged? |
@james-jwu @chensun could you please take a look and approve? |
Signed-off-by: ddalvi <[email protected]>
Description of your changes:
Resolves #10925
Converts the KFP SDK Execution test to a GH Action Workflow.
Here's a working GH Action run on my fork: https://github.com/DharmitD/data-science-pipelines-argo/actions/runs/9751594133/job/26913514655
PR to remove the KFP Execution test from prow config: GoogleCloudPlatform/oss-test-infra#2313
Checklist: