Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dev docs for kfp/sdk #11046

Merged
merged 1 commit into from
Jul 30, 2024
Merged

add dev docs for kfp/sdk #11046

merged 1 commit into from
Jul 30, 2024

Conversation

HumairAK
Copy link
Collaborator

Description of your changes:

Furthers: #10993

Add detailed instructions for contributors on how they can set up their sdk development environment.

api/Makefile Outdated Show resolved Hide resolved
sdk/CONTRIBUTING.md Show resolved Hide resolved
api/Makefile Outdated Show resolved Hide resolved
api/Makefile Outdated Show resolved Hide resolved
kubernetes_platform/Makefile Outdated Show resolved Hide resolved
kubernetes_platform/Makefile Outdated Show resolved Hide resolved
kubernetes_platform/Makefile Show resolved Hide resolved
sdk/CONTRIBUTING.md Outdated Show resolved Hide resolved
sdk/CONTRIBUTING.md Outdated Show resolved Hide resolved
sdk/CONTRIBUTING.md Outdated Show resolved Hide resolved
@HumairAK HumairAK force-pushed the sdk-docs branch 5 times, most recently from 285f905 to f3cbc5b Compare July 26, 2024 18:24
sdk/CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gregsheremeta
Copy link
Contributor

/lgtm

@HumairAK
Copy link
Collaborator Author

cc @chensun / @james-jwu

sdk/CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Humair Khan <[email protected]>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gregsheremeta
Copy link
Contributor

/lgtm

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, franciscojavierarceo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit eea7d48 into kubeflow:master Jul 30, 2024
12 checks passed
droctothorpe pushed a commit to droctothorpe/pipelines that referenced this pull request Aug 13, 2024
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants