-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix failing SDK tests by creating Python virtual environment #11300
Conversation
Hi @VaniHaripriya. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
40e3996
to
00aad4c
Compare
Signed-off-by: vmudadla <[email protected]>
00aad4c
to
306e2f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VaniHaripriya I'm approving it. But we probably need to to the same for all workflows that run pip install
.
Can you please send a follow up PR for the other ones?
You can search for pip install
in the .github
directory to find them.
/lgtm
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbelmiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@VaniHaripriya everything is passing now. I think we can ignore the other ones for now and keep an eye on the CI. |
…ubeflow#11300) Signed-off-by: vmudadla <[email protected]>
Description of your changes:
Resolves the failing KFP SDK Tests -https://github.com/kubeflow/pipelines/actions/runs/11351867593/job/31573385411
Checklist: