Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix failing SDK tests by creating Python virtual environment #11300

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

VaniHaripriya
Copy link
Contributor

@VaniHaripriya VaniHaripriya commented Oct 15, 2024

Description of your changes:

Resolves the failing KFP SDK Tests -https://github.com/kubeflow/pipelines/actions/runs/11351867593/job/31573385411

  • Used python virtual environment to install python packages in the test.

Checklist:

Copy link

Hi @VaniHaripriya. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Oct 15, 2024
@github-actions github-actions bot added ci-passed All CI tests on a pull request have passed and removed ci-passed All CI tests on a pull request have passed labels Oct 16, 2024
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VaniHaripriya I'm approving it. But we probably need to to the same for all workflows that run pip install.

Can you please send a follow up PR for the other ones?

You can search for pip install in the .github directory to find them.

image

/lgtm
/ok-to-test

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit aec2856 into kubeflow:master Oct 16, 2024
12 checks passed
@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 16, 2024
@hbelmiro
Copy link
Contributor

But we probably need to to the same for all workflows that run pip install.

Can you please send a follow up PR for the other ones?

@VaniHaripriya everything is passing now. I think we can ignore the other ones for now and keep an eye on the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed All CI tests on a pull request have passed lgtm ok-to-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants