WIP: test: Re-enable KFP Dockerfile-CLI component SDK unit test #11305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
DharmitD
changed the title
DharmitD
changed the title
DharmitD
changed the title
DharmitD
force-pushed
the
sdk-failed-test
branch
from
c42c14d
to
b87eee2
Compare
HumairAK
reviewed
Oct 22, 2024
Removed the skip unit test decorator that was previously added to bypass the test due to failure (referencing issue kubeflow#11038). The issue reported in kubeflow#11038 was caused due to the Dockerfile referencing to Python 3.7. With the Python version updated to 3.9, the test now passes consistently. This commit re-enables the test to ensure proper validation of Dockerfile creation and KFP package. Signed-off-by: ddalvi <[email protected]>
DharmitD
force-pushed
the
sdk-failed-test
branch
from
b87eee2
to
c0f0486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the skip unit test decorator that was previously added to bypass the test due to failure (referencing issue #11038).
The issue reported in #11038 was caused due to the Dockerfile referencing to Python 3.7. With the Python version updated to 3.9 (done as part of this commit), the test now passes consistently. This commit re-enables the test to ensure proper validation of Dockerfile creation and KFP package.
Description of your changes:
Checklist: