Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update test READMEs to reflect correct information on testing workflows #11445

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

DharmitD
Copy link
Contributor

@DharmitD DharmitD commented Dec 6, 2024

Description of your changes:

  • Remove obsolete information related to Prow tests, and gcloud dependency, since we've moved to GH Action Workflows/ Kind.
  • Add details related to the newly added GHA workflows and how to replicate them locally/manually using Kind clusters.

Resolves #11061

Checklist:

@google-oss-prow google-oss-prow bot requested review from gkcalat and rimolive December 6, 2024 15:00
@DharmitD DharmitD changed the title Update test READMEs to reflect correct information on testing workflows [chore] Update test READMEs to reflect correct information on testing workflows Dec 6, 2024
@DharmitD DharmitD changed the title [chore] Update test READMEs to reflect correct information on testing workflows chore: Update test READMEs to reflect correct information on testing workflows Dec 6, 2024
@rimolive
Copy link
Member

rimolive commented Dec 6, 2024

/lgtm

@VaniHaripriya
Copy link
Contributor

/lgtm

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/README.md Outdated Show resolved Hide resolved
test/kfp-functional-test/README.md Outdated Show resolved Hide resolved
test/kfp-functional-test/README.md Outdated Show resolved Hide resolved
@DharmitD
Copy link
Contributor Author

DharmitD commented Dec 7, 2024

Update/remove:

Thanks! I updated both these READMEs to point to the right files.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hbelmiro
Copy link
Contributor

hbelmiro commented Dec 9, 2024

@chensun @HumairAK can you please approve if that makes sense to you?

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 399a597 into kubeflow:master Dec 18, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove obsolete README files after migrating tests to GitHub Actions
5 participants