Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Update client-go and controller-runtime #11473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): Update client-go and controller-runtime #11473

wants to merge 1 commit into from

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Dec 18, 2024 •
edited
Loading

Description of your changes:

This updates k8s.io/client-go to v0.30.1 and sigs.k8s.io/controller-runtime to v0.18.6. Updating any higher requires updating github.com/argoproj/argo-workflows/v3 which requires updating to Go 1.23 which isn't widely available in base container images yet.

Checklist:

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow Google OSS Prow
Copy link

Hi @mprahl. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mprahl mprahl force-pushed the upgrade-controller-runtime branch 10 times, most recently from 5887e81 to 168310f Compare December 18, 2024 19:42
@mprahl
Copy link
Contributor Author

mprahl commented Dec 18, 2024

Sorry about the noise on this one. I had some issues with the license check but upgrading go-license fixed the segfault that was being encountered.

/cc @HumairAK

@google-oss-prow google-oss-prow bot requested a review from HumairAK December 18, 2024 20:12
@mprahl
Copy link
Contributor Author

mprahl commented Dec 18, 2024

It seems that the "KFP Samples / KFP Samples - K8s v1.31.0" workflow flaked. Can someone please retry it?

@mprahl mprahl closed this Dec 19, 2024
@mprahl mprahl reopened this Dec 19, 2024
@mprahl
Copy link
Contributor Author

mprahl commented Dec 19, 2024

It seems that the "KFP Samples / KFP Samples - K8s v1.31.0" workflow flaked. Can someone please retry it?

I reopened the PR to restart the workflows.

@mprahl mprahl force-pushed the upgrade-controller-runtime branch 2 times, most recently from a933ad1 to 88df99e Compare December 20, 2024 18:59
@mprahl
Copy link
Contributor Author

mprahl commented Dec 20, 2024

This is now rebased and it also includes the update to the crypto library like in #11482

hbelmiro
hbelmiro reviewed Dec 20, 2024
View reviewed changes
backend/src/agent/persistence/worker/persistence_worker_test.go Outdated
util.NewFakeTimeForEpoch(),
"PERSISTENCE_WORKER",
eventHandler,
false,
saver)
assert.NoError(t, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change it to require.NoError(t, err)? It seems like there's no point in continuing the execution in case of error.
Can you do that for the other assertions too?

@mprahl
chore(deps): Update client-go and controller-runtime
12331b0 
This updates k8s.io/client-go to v0.30.1 and
sigs.k8s.io/controller-runtime to v0.18.6. Updating any higher requires
updating github.com/argoproj/argo-workflows/v3 which requires updating
to Go 1.23 which isn't widely available in base container images yet.

Some other dependencies were updated for dependency resolution to
succeed.

Signed-off-by: mprahl <[email protected]>
@mprahl mprahl force-pushed the upgrade-controller-runtime branch from 88df99e to 12331b0 Compare December 20, 2024 19:58
@mprahl mprahl requested a review from hbelmiro December 20, 2024 19:58
hbelmiro
hbelmiro reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@google-oss-prow google-oss-prow bot added the lgtm label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbelmiro hbelmiro hbelmiro left review comments

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

@HumairAK HumairAK Awaiting requested review from HumairAK

Assignees

@hbelmiro hbelmiro

Labels
lgtm ok-to-test size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mprahl @hbelmiro