Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upgrade Minio to newest version with gateway (deprecated) #9658

Closed
wants to merge 2 commits into from
Closed

fix: Upgrade Minio to newest version with gateway (deprecated) #9658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc2a67f
updates Docker tag to use the latest version with GCS gateway available
koalalorenzo Jun 20, 2023
820276e
fmt + uses minio's newer image with GCS working and bug fixed
koalalorenzo Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/kustomize/env/azure/minio-azure-gateway/minio-azure-gateway-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
spec:
containers:
- name: minio
image: gcr.io/ml-pipeline/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance
image: gcr.io/ml-pipeline/minio:RELEASE.2022-04-16T04-26-02Z-license-compliance
args:
- gateway
- azure
Expand Down
4 changes: 2 additions & 2 deletions manifests/kustomize/env/gcp/minio-gcs-gateway/minio-gcs-gateway-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ spec:
serviceAccountName: kubeflow-pipelines-minio-gcs-gateway
containers:
- name: minio
image: gcr.io/ml-pipeline/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance
image: gcr.io/ml-pipeline/minio:RELEASE.2022-04-16T04-26-02Z-license-compliance
args:
- gateway
- gcs
- $(GCP_PROJECT_ID)
env:
env:
- name: GCP_PROJECT_ID
valueFrom:
configMapKeyRef:
Expand Down
58 changes: 29 additions & 29 deletions manifests/kustomize/third-party/minio/base/minio-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,33 +16,33 @@ spec:
app: minio
spec:
containers:
- args:
- server
- /data
env:
- name: MINIO_ACCESS_KEY
valueFrom:
secretKeyRef:
name: mlpipeline-minio-artifact
key: accesskey
- name: MINIO_SECRET_KEY
valueFrom:
secretKeyRef:
name: mlpipeline-minio-artifact
key: secretkey
image: gcr.io/ml-pipeline/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance
name: minio
ports:
- containerPort: 9000
volumeMounts:
- mountPath: /data
name: data
subPath: minio
resources:
requests:
cpu: 20m
memory: 100Mi
- args:
- server
- /data
env:
- name: MINIO_ACCESS_KEY
valueFrom:
secretKeyRef:
name: mlpipeline-minio-artifact
key: accesskey
- name: MINIO_SECRET_KEY
valueFrom:
secretKeyRef:
name: mlpipeline-minio-artifact
key: secretkey
image: gcr.io/ml-pipeline/minio:RELEASE.2022-04-16T04-26-02Z-license-compliance
name: minio
ports:
- containerPort: 9000
volumeMounts:
- mountPath: /data
name: data
subPath: minio
resources:
requests:
cpu: 20m
memory: 100Mi
volumes:
- name: data
persistentVolumeClaim:
claimName: minio-pvc
- name: data
persistentVolumeClaim:
claimName: minio-pvc
4 changes: 2 additions & 2 deletions test/tag_for_hosted.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ docker tag gcr.io/tfx-oss-public/ml_metadata_store_server:1.5.0 gcr.io/$PROJECT_
docker push gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/metadataserver:$SEM_VER
docker push gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/metadataserver:$MM_VER

docker tag gcr.io/ml-pipeline/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/minio:$SEM_VER
docker tag gcr.io/ml-pipeline/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/minio:$MM_VER
docker tag gcr.io/ml-pipeline/minio:RELEASE.2022-04-16T04-26-02Z-license-compliance gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/minio:$SEM_VER
docker tag gcr.io/ml-pipeline/minio:RELEASE.2022-04-16T04-26-02Z-license-compliance gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/minio:$MM_VER
docker push gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/minio:$SEM_VER
docker push gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/minio:$MM_VER

Expand Down
2 changes: 1 addition & 1 deletion third_party/minio/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ RUN sh /third_party/download_source.sh </third_party/minio/repo-MPL.txt


# Minio image
FROM minio/minio:RELEASE.2019-08-14T20-37-41Z
FROM minio/minio:RELEASE.2022-04-16T04-26-02Z

# Copy concatenated license file
COPY third_party/minio/license.txt /third_party/license.txt
Expand Down
2 changes: 1 addition & 1 deletion third_party/minio/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ set -e
# $PROJECT: gcp project

RELEASE_PROJECT=ml-pipeline
TAG=RELEASE.2019-08-14T20-37-41Z-license-compliance
TAG=RELEASE.2022-04-16T04-26-02Z-license-compliance

gcloud builds submit --config third_party/minio/cloudbuild.yaml . \
--substitutions=TAG_NAME="$TAG" --project "$PROJECT"
Expand Down