-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk: update local execution limitations #3736
base: master
Are you sure you want to change the base?
sdk: update local execution limitations #3736
Conversation
c9a2c2c
to
6df8d13
Compare
/assign @chensun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit. Mostly LGTM.
1825253
to
1f653f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Consider changing "you need to" to "you must" in a future PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sen-sam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: connor-mccarthy <[email protected]>
1f653f5
to
3c2a950
Compare
No description provided.