-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block web crawlers on v1.9-branch
#3862
Open
thesuperzapper
wants to merge
5
commits into
kubeflow:v1.9-branch
Choose a base branch
from
thesuperzapper:fix-robots/v1.9-branch
base: v1.9-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−13
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4e5c196
Block web crawlers on `v1.9-branch`
thesuperzapper 68c2a9f
Enable archived version header
thesuperzapper b5a7f15
Backport changes from #3863
thesuperzapper 1a5e5ca
Remove `Archive: ` version dropdown prefix
thesuperzapper cdae0e4
Improve archived_version banner
thesuperzapper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<!-- Check the variable that indicates whether this is an archived doc set. If yes, display a banner. --> | ||
{{- $latest_version_url := .Site.Params.url_latest_version }} | ||
{{- $current_version := replace .Site.Params.version "v" "" | markdownify }} | ||
{{- if .Site.Params.archived_version }} | ||
<style> | ||
.version-banner { | ||
padding: 1.5rem; | ||
margin: 2rem 0; | ||
max-width: 40rem; | ||
border-style: solid; | ||
border-color: #f0ad4e; | ||
background-color: #faf5b6; | ||
border-radius: 0.25rem; | ||
} | ||
.version-banner h3 { | ||
margin-top: 0; | ||
margin-bottom: 0.6em; | ||
font-size: 1.25em; | ||
} | ||
.version-banner p { | ||
margin-top: 0; | ||
margin-bottom: 0; | ||
} | ||
</style> | ||
<div class="version-banner"> | ||
<h3>You are viewing documentation for <strong>Kubeflow {{ $current_version }}</strong></h3> | ||
<p> | ||
This is a static snapshot from the time of the Kubeflow {{ $current_version }} release. | ||
<br> | ||
For up-to-date information, see the <a href="{{ $latest_version_url | safeURL }}">latest version</a>. | ||
</p> | ||
</div> | ||
{{- end }} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, do the www prefix instead of kubeflow.org change anything on google indexing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or did you change the other PRs for the sake of consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google prefers direct links, and only adds to the "backlinks" count for real links, not ones that are redirected (at least that's my experience).