Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #3809 #3876

Closed
wants to merge 1 commit into from
Closed

Resolves #3809 #3876

wants to merge 1 commit into from

Conversation

varodrig
Copy link

Resolves #3809

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @varodrig. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: varodrig <[email protected]>
@varodrig
Copy link
Author

After creating this PR, I noticed that there's another one in progress #3830, but it seems it's missing the redirect file. I tested this locally, let me know if you want me to run any other tests.

Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please never update any lines in the redirects file, otherwise you will create 404s.

If you move a page (not what you are doing in this PR) please ADD a line to the redirects file.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@thesuperzapper
Copy link
Member

As the redirect file should not be updated, I am going to close this.

For reference, the purpose of the redirect file is to be a catalog of moved pages, so all old links to the website end up on the current page (even if the pages have been moved multiple times, so redirects point to other redirects).

/close

Copy link

@thesuperzapper: Closed this PR.

In response to this:

As the redirect file should not be updated, I am going to close this.

For reference, the purpose of the redirect file is to be a catalog of moved pages, so all old links to the website end up on the current page (even if the pages have been moved multiple times, so redirects point to other redirects).

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken links in Central Dashboard
3 participants