-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add load balancer health check #3216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 夜微澜 <[email protected]>
zbb88888
requested changes
Sep 21, 2023
lb 健康检查:
todo://
|
Signed-off-by: 夜微澜 <[email protected]>
Signed-off-by: 夜微澜 <[email protected]>
Signed-off-by: 夜微澜 <[email protected]>
qiutingjun
force-pushed
the
health
branch
3 times, most recently
from
October 9, 2023 08:23
a227dc0
to
f6b6ee6
Compare
Signed-off-by: 夜微澜 <[email protected]>
Signed-off-by: 夜微澜 <[email protected]>
Signed-off-by: 夜微澜 <[email protected]>
zbb88888
reviewed
Oct 13, 2023
please attach the docs pr |
Signed-off-by: 夜微澜 <[email protected]>
zbb88888
approved these changes
Oct 17, 2023
hi @oilbeater, could you help review? |
|
oilbeater
requested changes
Oct 17, 2023
Signed-off-by: 夜微澜 <[email protected]>
Signed-off-by: 夜微澜 <[email protected]>
oilbeater
approved these changes
Oct 19, 2023
zbb88888
pushed a commit
that referenced
this pull request
Oct 19, 2023
* add load balancer health check Signed-off-by: 夜微澜 <[email protected]> * reuse a VIP named by subnet to health check Signed-off-by: 夜微澜 <[email protected]> * clear health check while slr deleted Signed-off-by: 夜微澜 <[email protected]> * fix health check unit test Signed-off-by: 夜微澜 <[email protected]> * fix go.mod Signed-off-by: 夜微澜 <[email protected]> * format && clean Signed-off-by: 夜微澜 <[email protected]> * revert changes to makefile parameters Signed-off-by: 夜微澜 <[email protected]> * update format Signed-off-by: 夜微澜 <[email protected]> --------- Signed-off-by: 夜微澜 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
add health check for load balancer
[ovn-nb document](https://www.ovn.org/support/dist-docs/ovn-nb.5.html)
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at c66e373
This pull request adds support for ip port mappings and health checks to load balancers for services and endpoints in the
kube-ovn
controller. It also improves the readability, consistency, and error handling of the code in various files, updates the module versions ingo.mod
, and adds unit tests for the new functionality. Additionally, it renames some files to follow the Go naming convention and avoid linting errors.🤖 Generated by Copilot at c66e373
HOW
🤖 Generated by Copilot at c66e373
go.mod
file (link, link)Makefile
(link)mocks/pkg/ovs/interface.go
(link, link, link, link, link, link, link, link, link)pkg/ovs/ovn-nb-load_balancer_health_check.go
) that implements the LoadBalancerHealthCheck interface and provides the methods for managing load balancer health checks in the OVN NB database (link)pkg/ovs/ovn-nb-load_balancer_health_check_test.go
) that provides unit tests for the LoadBalancerHealthCheck interface and its methods (link)pkg/ovs/ovn-nb-nat.go
to improve error handling and debugging (link)