-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support vpc configuration of multiple external network segments through label and crd #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbb88888
requested changes
Sep 27, 2023
zbb88888
requested changes
Sep 28, 2023
@zcq98 this is a really cool feature! i'm waiting for merging this pr =) let me know if i can help you. |
zbb88888
requested changes
Oct 9, 2023
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
zbb88888
requested changes
Oct 10, 2023
Signed-off-by: zcq98 <[email protected]>
zbb88888
requested changes
Oct 10, 2023
Signed-off-by: zcq98 <[email protected]>
zbb88888
reviewed
Oct 11, 2023
Signed-off-by: zcq98 <[email protected]>
zbb88888
approved these changes
Oct 11, 2023
Signed-off-by: zcq98 <[email protected]>
1 task
hi @oilbeater , could you help review this ? |
Signed-off-by: zcq98 <[email protected]>
oilbeater
requested changes
Oct 17, 2023
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
zbb88888
approved these changes
Oct 18, 2023
zbb88888
pushed a commit
that referenced
this pull request
Oct 18, 2023
…gh label and crd (#3264) * add externalSubnet field support for vpc * custom vpc get chassis from node label * custom vpc add external based on ExternalSubnets * support externalsubnets update * compatible with default external * fix custom vpc default external localnet create * update addExternalSubnets status * crd for addExternalSubnets * add additionalPrinterColumn extraExternalSubnets --------- Signed-off-by: zcq98 <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at 6ac6836
This pull request adds support for multiple external subnets for a VPC in the
kubeovn
API and controller. It modifies theVpcSpec
andVpcStatus
structs, thevpc.go
andsubnet.go
files, and comments out the BFD and custom VPC static route features, which are incompatible with the new feature.🤖 Generated by Copilot at 6ac6836
HOW
🤖 Generated by Copilot at 6ac6836
ExternalSubnets
to theVpcSpec
andVpcStatus
structs intypes.go
to store the desired and actual external subnets for a VPC (link, link)sort
package invpc.go
to sort the external subnets in thehandleAddOrUpdateVpc
function (link)handleDelVpc
function invpc.go
to loop over the external subnets in the VPC spec and callhandleDelVpcExternalSubnets
for each subnet (link)handleAddOrUpdateVpc
function invpc.go
to check the external subnets in the VPC spec and status, and callhandleAddVpcExternalSubnets
orhandleDelVpcExternalSubnets
for each subnet that is added or removed (link)handleAddVpcExternal
function invpc.go
tohandleAddVpcExternalSubnets
and add a parametersubnet
to specify the external subnet to connect (link)c.config.ExternalGatewaySwitch
to thesubnet
parameter in thehandleAddVpcExternalSubnets
function invpc.go
, and replace the logic to get the gateway chassis from the config map to the node labels (link)c.acquireIPAddress
andc.createOrUpdateCrdOvnEip
in thehandleAddVpcExternalSubnets
function invpc.go
to use thesubnet
parameter instead of thec.config.ExternalGatewaySwitch
(link)c.OVNNbClient.CreateLogicalPatchPort
in thehandleAddVpcExternalSubnets
function invpc.go
to use thesubnet
parameter instead of thec.config.ExternalGatewaySwitch
, and thelspName
andlrpName
variables to use thesubnet
parameter instead of thec.config.ExternalGatewaySwitch
(link)vpc.Status.ExternalSubnets
slice in thehandleAddVpcExternalSubnets
function invpc.go
if it is not already in the slice (link)handleDelVpcExternal
function invpc.go
tohandleDelVpcExternalSubnets
and add a parametersubnet
to specify the external subnet to disconnect (link)c.config.ExternalGatewaySwitch
to thesubnet
parameter in thehandleDelVpcExternalSubnets
function invpc.go
, and thelspName
andlrpName
variables to use thesubnet
parameter instead of thec.config.ExternalGatewaySwitch
(link)vpc.Status.ExternalSubnets
slice in thehandleDelVpcExternalSubnets
function invpc.go
if it is in the slice (link)reconcileCustomVpcStaticRoute
in thereconcileSubnet
function insubnet.go
, which is used to reconcile the static routes for a custom VPC (link)handleAddOrUpdateVpc
function invpc.go
, which is not compatible with the multiple external subnets feature (link)