Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ovn ic ecmp enhance 1.11 #3609

Merged
merged 13 commits into from
Jan 16, 2024
Merged

Ovn ic ecmp enhance 1.11 #3609

merged 13 commits into from
Jan 16, 2024

Conversation

changluyi
Copy link
Collaborator

@changluyi changluyi commented Jan 7, 2024 •
edited
Loading

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  1. 将ovn-ic逻辑从kube-ovn-controller剥离出来， 使用ovn-ic-client实现。
  2. 控制器使用ovn-ic-server去部署，不再使用docker 或者containerd单独部署
  3. 支持集群互联ECMP，并支持ECMP path 扩缩容
  4. 退出集群互联时会彻底清理控制器上和 当前集群ic相关的db。
  5. 增加kubectl ko icsbctl/icnbctl 命令
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

WHAT

copilot:summary

copilot:poem

HOW

copilot:walkthrough

@changluyi changluyi force-pushed the ovn-ic-ecmp-enhance-1.11 branch from 94646a1 to 69de7f9 Compare January 8, 2024 01:33
@changluyi
conflict merge
21fb49b 
Signed-off-by: changluyi <[email protected]>
@changluyi
golang lint
f1f54b4 
Signed-off-by: changluyi <[email protected]>
@changluyi changluyi force-pushed the ovn-ic-ecmp-enhance-1.11 branch from f0c1363 to f1f54b4 Compare January 8, 2024 03:34
@changluyi
change chmod
acc9088 
Signed-off-by: Changlu Yi <[email protected]>
@changluyi
fix
343e259 
Signed-off-by: changluyi <[email protected]>
@changluyi
add clean up
c1f1446 
Signed-off-by: changluyi <[email protected]>
oilbeater
oilbeater requested changes Jan 9, 2024
View reviewed changes
dist/images/install.sh
@@ -3559,6 +3559,104 @@ spec:
optional: true
secretName: kube-ovn-tls
---
kind: Deployment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ovn-ic-client 应该是选装

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

@changluyi
add switch for enable_ic
dbd9a01 
Signed-off-by: Changlu Yi <[email protected]>
@changluyi changluyi force-pushed the ovn-ic-ecmp-enhance-1.11 branch from d0d1127 to dbd9a01 Compare January 9, 2024 07:20
zhangzujian
zhangzujian reviewed Jan 11, 2024
View reviewed changes
dist/images/install.sh Outdated Show resolved Hide resolved
oilbeater
oilbeater requested changes Jan 15, 2024
View reviewed changes
kubeovn-helm/values.yaml Outdated
@@ -52,6 +52,7 @@ func:
CHECK_GATEWAY: true
LOGICAL_GATEWAY: false
ENABLE_BIND_LOCAL_IP: true
ENABLE_IC: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认值需要是 false

@changluyi
enable ic set default to false, and when upgrade need to check whethe…
a6fee93 
…r cluster enable ic.

Signed-off-by: Changlu Yi <[email protected]>
@changluyi
fix
c717404 
Signed-off-by: Changlu Yi <[email protected]>
@changluyi changluyi merged commit 7b863fb into release-1.11 Jan 16, 2024
45 checks passed
@changluyi changluyi deleted the ovn-ic-ecmp-enhance-1.11 branch January 16, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangzujian zhangzujian zhangzujian left review comments

@oilbeater oilbeater oilbeater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@changluyi @oilbeater @zhangzujian