Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cache.MetaObjectToName() to get namespaced name #4842

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@coveralls
Copy link

coveralls commented Dec 17, 2024

Pull Request Test Coverage Report for Build 12387433755

Details

  • 0 of 129 (0.0%) changed or added relevant lines in 32 files are covered.
  • 67 unchanged lines in 27 files lost coverage.
  • Overall coverage increased (+0.2%) to 22.137%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/controller.go 0 1 0.0%
pkg/controller/deployment.go 0 1 0.0%
pkg/controller/namespace.go 0 1 0.0%
pkg/controller/admin_network_policy.go 0 2 0.0%
pkg/controller/baseline_admin_network_policy.go 0 2 0.0%
pkg/controller/endpoint.go 0 2 0.0%
pkg/controller/switch_lb_rule.go 0 2 0.0%
pkg/controller/ip.go 0 3 0.0%
pkg/controller/ippool.go 0 3 0.0%
pkg/controller/kubevirt.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller/subnet.go 1 7.08%
pkg/controller/vpc.go 1 0.0%
pkg/controller/baseline_admin_network_policy.go 1 2.11%
pkg/controller/inspection.go 1 0.0%
pkg/controller/ippool.go 1 0.0%
pkg/controller/admin_network_policy.go 1 9.88%
pkg/controller/namespace.go 1 0.0%
pkg/controller/endpoint.go 1 0.0%
pkg/controller/vpc_nat_gw_eip.go 2 0.0%
pkg/controller/node.go 2 0.0%
Totals Coverage Status
Change from base Build 12387240332: 0.2%
Covered Lines: 10169
Relevant Lines: 45937

💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review December 17, 2024 12:45
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 17, 2024
@dosubot dosubot bot added the refactor label Dec 17, 2024
@zhangzujian zhangzujian force-pushed the fix-key branch 2 times, most recently from 21e1cd2 to f4b33cb Compare December 17, 2024 12:50
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 18, 2024
@zhangzujian zhangzujian merged commit 96ad245 into kubeovn:master Dec 18, 2024
15 checks passed
@zhangzujian zhangzujian deleted the fix-key branch December 18, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants