Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document parameter for parallel CCM service reconciliation #1517

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

embik
Copy link
Member

@embik embik commented Sep 18, 2023

This is the documentation companion PR to kubermatic/kubeone#2916, documenting the newly added parameter that can be passed to the CCM addons to configure parallel reconciliation of Service objects.

@embik embik self-assigned this Sep 18, 2023
@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Sep 18, 2023
@embik
Copy link
Member Author

embik commented Sep 18, 2023

/hold

until feature PR is merged.

@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2023
@xmudrii
Copy link
Member

xmudrii commented Sep 18, 2023

/assign

@embik
Copy link
Member Author

embik commented Sep 18, 2023

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny follow up.
/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 46e1d9221b037ce05eb8d4896b93d615b1abdb0d

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 3982bb8 into kubermatic:master Sep 18, 2023
@embik embik deleted the kubeone-ccm-variable branch September 18, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants