Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use upstream kube-rbac-proxy from quay.io #65

Merged
merged 1 commit into from
Sep 23, 2024
Merged

use upstream kube-rbac-proxy from quay.io #65

merged 1 commit into from
Sep 23, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Sep 20, 2024

What this PR does / why we need it:
As per kubernetes-sigs/kubebuilder#3907

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Use `quay.io/brancz/kube-rbac-proxy` to fetch kube-rbac-proxy.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2024
@xrstf xrstf self-assigned this Sep 20, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8dbdabcf3c38cd29e95c939ef47e1ad0da055eb1

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@kubermatic-bot kubermatic-bot merged commit e391fff into main Sep 23, 2024
12 checks passed
@ahmedwaleedmalik
Copy link
Member

/cherry-pick release/v1.1

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #68

In response to this:

/cherry-pick release/v1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@xrstf xrstf

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrstf @kubermatic-bot @ahmedwaleedmalik