[release/v1.57] Remove TORCX_BINDIR from containerd binary call (#1762)

* [release/v1.57] Remove TORCX_BINDIR from containerd binary call Signed-off-by: Marvin Beckers <[email protected]> * [release/v1.57] Replace yamllint image Signed-off-by: Marvin Beckers <[email protected]> * bump operating-system-manager to v1.3.4 Signed-off-by: Marvin Beckers <[email protected]> * Bump OSM to v1.3.4 Signed-off-by: Marko Mudrinić <[email protected]> * Fix AWS and Hetzner E2E tests Signed-off-by: Marko Mudrinić <[email protected]> --------- Signed-off-by: Marvin Beckers <[email protected]> Signed-off-by: Marko Mudrinić <[email protected]> Co-authored-by: Marko Mudrinić <[email protected]>
kubermatic · Feb 20, 2024 · 08687d3 · 08687d3
1 parent 606df8f
commit 08687d3
Show file tree

Hide file tree

Showing 13 changed files with 19 additions and 16 deletions.
diff --git a/.prow/verify.yaml b/.prow/verify.yaml
@@ -83,11 +83,11 @@ presubmits:
       preset-goproxy: "true"
     spec:
       containers:
-        - image: quay.io/kubermatic/yamllint:0.1
+        - image: quay.io/kubermatic/build:go-1.20-node-18-13
           command:
-            - "sh"
-            - "-c"
-            - "yamllint -c .yamllint.conf ."
+            - "make"
+          args:
+            - "yamllint"
           resources:
             requests:
               memory: 32Mi

diff --git a/Makefile b/Makefile
@@ -67,6 +67,9 @@ clean:
 lint:
 	golangci-lint run -v
 
+yamllint:
+	yamllint -c .yamllint.conf .
+
 .PHONY: docker-image
 docker-image:
 	docker build --build-arg GO_VERSION=$(GO_VERSION) -t $(IMAGE_NAME) .

diff --git a/examples/operating-system-manager.yaml b/examples/operating-system-manager.yaml
@@ -990,7 +990,7 @@ spec:
     spec:
       serviceAccountName: operating-system-manager-webhook
       containers:
-        - image: quay.io/kubermatic/operating-system-manager:v1.3.3
+        - image: quay.io/kubermatic/operating-system-manager:v1.3.4
           imagePullPolicy: Always
           name: webhook
           command:
@@ -1318,7 +1318,7 @@ spec:
     spec:
       serviceAccountName: operating-system-manager
       containers:
-        - image: quay.io/kubermatic/operating-system-manager:v1.3.3
+        - image: quay.io/kubermatic/operating-system-manager:v1.3.4
           imagePullPolicy: Always
           name: operating-system-manager
           command:

diff --git a/pkg/containerruntime/containerd.go b/pkg/containerruntime/containerd.go
@@ -96,7 +96,7 @@ cat <<EOF | tee /etc/systemd/system/containerd.service.d/10-machine-controller.c
 Restart=always
 Environment=CONTAINERD_CONFIG=/etc/containerd/config.toml
 ExecStart=
-ExecStart=/usr/bin/env PATH=\${TORCX_BINDIR}:\${PATH} \${TORCX_BINDIR}/containerd --config \${CONTAINERD_CONFIG}
+ExecStart=/usr/bin/env PATH=\${TORCX_BINDIR}:\${PATH} containerd --config \${CONTAINERD_CONFIG}
 EOF
 
 systemctl daemon-reload

diff --git a/pkg/userdata/flatcar/testdata/cloud-init_v1.24.0.yaml b/pkg/userdata/flatcar/testdata/cloud-init_v1.24.0.yaml
@@ -462,7 +462,7 @@ write_files:
     Restart=always
     Environment=CONTAINERD_CONFIG=/etc/containerd/config.toml
     ExecStart=
-    ExecStart=/usr/bin/env PATH=\${TORCX_BINDIR}:\${PATH} \${TORCX_BINDIR}/containerd --config \${CONTAINERD_CONFIG}
+    ExecStart=/usr/bin/env PATH=\${TORCX_BINDIR}:\${PATH} containerd --config \${CONTAINERD_CONFIG}
     EOF
 
     systemctl daemon-reload

diff --git a/pkg/userdata/flatcar/testdata/cloud-init_v1.24.9.yaml b/pkg/userdata/flatcar/testdata/cloud-init_v1.24.9.yaml
@@ -462,7 +462,7 @@ write_files:
     Restart=always
     Environment=CONTAINERD_CONFIG=/etc/containerd/config.toml
     ExecStart=
-    ExecStart=/usr/bin/env PATH=\${TORCX_BINDIR}:\${PATH} \${TORCX_BINDIR}/containerd --config \${CONTAINERD_CONFIG}
+    ExecStart=/usr/bin/env PATH=\${TORCX_BINDIR}:\${PATH} containerd --config \${CONTAINERD_CONFIG}
     EOF
 
     systemctl daemon-reload

diff --git a/pkg/userdata/flatcar/testdata/cloud-init_v1.25.0.yaml b/pkg/userdata/flatcar/testdata/cloud-init_v1.25.0.yaml
@@ -462,7 +462,7 @@ write_files:
     Restart=always
     Environment=CONTAINERD_CONFIG=/etc/containerd/config.toml
     ExecStart=
-    ExecStart=/usr/bin/env PATH=\${TORCX_BINDIR}:\${PATH} \${TORCX_BINDIR}/containerd --config \${CONTAINERD_CONFIG}
+    ExecStart=/usr/bin/env PATH=\${TORCX_BINDIR}:\${PATH} containerd --config \${CONTAINERD_CONFIG}
     EOF
 
     systemctl daemon-reload

diff --git a/pkg/userdata/flatcar/testdata/containerd.yaml b/pkg/userdata/flatcar/testdata/containerd.yaml
@@ -441,7 +441,7 @@ write_files:
     Restart=always
     Environment=CONTAINERD_CONFIG=/etc/containerd/config.toml
     ExecStart=
-    ExecStart=/usr/bin/env PATH=\${TORCX_BINDIR}:\${PATH} \${TORCX_BINDIR}/containerd --config \${CONTAINERD_CONFIG}
+    ExecStart=/usr/bin/env PATH=\${TORCX_BINDIR}:\${PATH} containerd --config \${CONTAINERD_CONFIG}
     EOF
 
     systemctl daemon-reload

diff --git a/pkg/userdata/flatcar/testdata/ignition_v1.24.0.json b/pkg/userdata/flatcar/testdata/ignition_v1.24.0.json
diff --git a/pkg/userdata/flatcar/testdata/ignition_v1.24.9.json b/pkg/userdata/flatcar/testdata/ignition_v1.24.9.json
diff --git a/pkg/userdata/flatcar/testdata/ignition_v1.25.0.json b/pkg/userdata/flatcar/testdata/ignition_v1.25.0.json
diff --git a/test/e2e/provisioning/all_e2e_test.go b/test/e2e/provisioning/all_e2e_test.go
@@ -703,7 +703,7 @@ func TestHetznerProvisioningE2E(t *testing.T) {
 		t.Fatal("Unable to run the test suite, HZ_E2E_TOKEN environment variable cannot be empty")
 	}
 
-	selector := OsSelector("ubuntu", "centos", "rockylinux")
+	selector := OsSelector("ubuntu", "rockylinux")
 
 	// act
 	params := []string{fmt.Sprintf("<< HETZNER_TOKEN >>=%s", hzToken)}

diff --git a/test/e2e/provisioning/helper.go b/test/e2e/provisioning/helper.go
@@ -239,7 +239,7 @@ func testScenario(t *testing.T, testCase scenario, cloudProvider string, testPar
 		scenarioParams = append(scenarioParams, fmt.Sprintf("<< DATA_DISK_SIZE >>=%v", 30))
 		scenarioParams = append(scenarioParams, fmt.Sprintf("<< DISK_SIZE >>=%v", 25))
 		scenarioParams = append(scenarioParams, fmt.Sprintf("<< CUSTOM-IMAGE >>=%v", ""))
-		scenarioParams = append(scenarioParams, fmt.Sprintf("<< MAX_PRICE >>=%s", "0.02"))
+		scenarioParams = append(scenarioParams, fmt.Sprintf("<< MAX_PRICE >>=%s", "0.023"))
 	}
 
 	if strings.Contains(cloudProvider, string(providerconfigtypes.CloudProviderEquinixMetal)) {