Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add machine deployment metrics #1879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajaSahil
Copy link

@rajaSahil rajaSahil commented Nov 19, 2024

What this PR does / why we need it:

  • add machine deployment metrics
# HELP machine_deployment_available_replicas The number of available replicas for a machine deployment
# TYPE machine_deployment_available_replicas gauge
machine_deployment_available_replicas{name="",namespace=""} 0
# HELP machine_deployment_ready_replicas The number of ready replicas for a machine deployment
# TYPE machine_deployment_ready_replicas gauge
machine_deployment_ready_replicas{name="",namespace=""} 0
# HELP machine_deployment_replicas The number of replicas defined for a machine deployment
# TYPE machine_deployment_replicas gauge
machine_deployment_replicas{name="",namespace=""} 0
# HELP machine_deployment_updated_replicas The number of replicas updated for a machine deployment
# TYPE machine_deployment_updated_replicas gauge
machine_deployment_updated_replicas{name="",namespace=""} 0

Which issue(s) this PR fixes:

Fixes #1767

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

 Add collector to expose machine deployment metrics

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/provided Denotes a PR that has a valid documentation reference. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 19, 2024
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2024
@rajaSahil
Copy link
Author

/assign @embik

@kubermatic-bot
Copy link
Contributor

@rajaSahil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-lint bc715cd link true /test pull-machine-controller-lint

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed docs/provided Denotes a PR that has a valid documentation reference. labels Nov 19, 2024
@embik
Copy link
Member

embik commented Jan 6, 2025

@rajaSahil did you see the linter errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose metrics for MachineDeployment status
3 participants