-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .readthedocs.yaml config file to fix docs pipeline #2254
base: master
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @aapjeisbaas! |
why are many lines commented out? |
I found those lines in the old working build runs and kept them for reference. |
/assign @yliaog |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aapjeisbaas, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Fix the broken read the docs build: https://readthedocs.org/projects/kubernetes/builds/
Special notes for your reviewer:
Build works on my branch and output looks the same but witt up to date readme:
https://app.readthedocs.org/projects/python-kubernetes-client/builds/25015241/
My other documentation questions:
Why is this not in the published docs:
https://github.com/kubernetes-client/python/blob/master/kubernetes/README.md
Yes the github interface works but a published version would be nicer to use.
Why are these pages empty:
https://python-kubernetes-client.readthedocs.io/en/latest/kubernetes.client.models.v1_container.html