Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with explanation of EKS Pod Identity configuration with EFS CSI Controller #1422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leondkr
Copy link

@leondkr leondkr commented Aug 1, 2024

Update Controller Pod Identity config description

Is this a bug fix or adding new feature?

Feature

What is this PR about? / Why do we need it?

Adds more details of integration between EKS Pod Identities feature and k8s service account of EFS CSI controller when the controller wants to communicate with EFS services using sufficient permissions.

What testing is done?

Here is the controller logs when we do not use arn:aws:iam::aws:policy/service-role/AmazonEFSCSIDriverPolicy before and after:

I0801 07:02:02.139270       1 controller.go:335] Using /pvc-a2755de8-c8fb-4ecd-b866-d86a43186784 as the access point directory.
E0801 07:02:02.175852       1 driver.go:107] GRPC error: rpc error: code = Unauthenticated desc = Access Denied. Please ensure you have the right AWS permissions: Access denied
I0801 07:03:50.748840       1 controller.go:328] Using PV name for access point directory.
I0801 07:03:50.748911       1 controller.go:335] Using /pvc-c380cab3-3f23-466b-acc6-4b39fa52fd9b as the access point directory.

Here is the events log of my PVC:

Events:
  Type    Reason                 Age   From                                                                                      Message
  ----    ------                 ----  ----                                                                                      -------
  Normal  ExternalProvisioning   19m   persistentvolume-controller                                                               Waiting for a volume to be created either by the external provisioner 'efs.csi.aws.com' or manually by the system administrator. If volume creation is delayed, please verify that the provisioner is running and correctly registered.
  Normal  Provisioning           19m   efs.csi.aws.com_efs-csi-controller-6b6999698f-bvllr_9bea6a5d-81e3-4e23-9905-b92af19e6e46  External provisioner is provisioning volume for claim "cicd/jenkins"
  Normal  ProvisioningSucceeded  19m   efs.csi.aws.com_efs-csi-controller-6b6999698f-bvllr_9bea6a5d-81e3-4e23-9905-b92af19e6e46  Successfully provisioned volume pvc-c380cab3-3f23-466b-acc6-4b39fa52fd9b

Copy link

linux-foundation-easycla bot commented Aug 1, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: leondkr / name: Binh Nguyen (1019dbd)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leondkr
Once this PR has been reviewed and has the lgtm label, please assign ashley-wenyizha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @leondkr!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @leondkr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 1, 2024
docs/README.md Outdated Show resolved Hide resolved
@mskanth972
Copy link
Contributor

Hi @leondkr, thanks for the PR. Can you squash the commits so that I can trigger the tests?

@leondkr
Copy link
Author

leondkr commented Aug 8, 2024

Hi @leondkr, thanks for the PR. Can you squash the commits so that I can trigger the tests?

Hi @mskanth972, I squashed into a single one. Please check if any further action required. Thanks!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants