Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add portRangeUpperBound to be exposed in the helm chart #1469

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: add portRangeUpperBound to be exposed in the helm chart #1469

wants to merge 11 commits into from

Conversation

cescribanohs
Copy link

@cescribanohs cescribanohs commented Oct 10, 2024 •
edited
Loading

We have a large amount of pvc deploys in our cluster and often we reach the error Could not mount pvc due to available port

Even the port_range_upper_bound property has been increased recently

aws-efs-csi-driver/pkg/driver/efs_watch_dog.go

Line 74 in b0af6bc

# Define the port range that the TLS tunnel will choose from
still we need this number to be configurable as FIPS it is at the moment.

For this reason, adding a new helm value that can instantiated from a kustomize.config.k8s.io/v1beta1 component it is our goal.

What testing is done?

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 10, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cescribanohs
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @cescribanohs!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @cescribanohs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2024
avanish23
avanish23 reviewed Oct 12, 2024
View reviewed changes
Copy link
Contributor

@avanish23 avanish23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add check to ensure PORT_RANGE_UPPER_BOUND is greater than 20049.

Mostly the PR looks good.
Thanks!

pkg/driver/efs_watch_dog.go Outdated
@@ -284,7 +285,11 @@ func (w *execWatchdog) updateConfig(efsClientSource string) error {
// used on Fargate, IMDS queries suffice otherwise
region := os.Getenv("AWS_DEFAULT_REGION")
fipsEnabled := os.Getenv("FIPS_ENABLED")
efsCfg := efsUtilsConfig{EfsClientSource: efsClientSource, Region: region, FipsEnabled: fipsEnabled}
portRangeUpperBound, found := os.LookupEnv("PORT_RANGE_UPPER_BOUND")
Copy link
Contributor

@avanish23 avanish23 Oct 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to check the condition here, you can assign the portRangeUpperBound as you have already added it under env in the deployment helm charts.
portRangeUpperBound := os.Getenv("PORT_RANGE_UPPER_BOUND")

Also, one check should be added to ensure that portRangeUpperBound is always greater than portRangeLowerBound(20049).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if there is something else or just waiting you resolve the conversation and provide the approval.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging @mskanth972 to help with approval.
Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all, when do you think it can be approved? Many thanks

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 14, 2024
@mskanth972
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2024
@cescribanohs
Copy link
Author

/ok-to-test

All test are passing right now. Ty

@cescribanohs
Copy link
Author

Hi, any approvals or comments are welcomed. Thank you

@mskanth972
Copy link
Contributor

Don't we need to update node-daemonset yaml file?
I did not test this but is it necessary to update both Controller and Daemonset files to include the PORT_RANGE_UPPER_BOUND and also did you get chance to test this?

@cescribanohs
Copy link
Author

Don't we need to update node-daemonset yaml file? I did not test this but is it necessary to update both Controller and Daemonset files to include the PORT_RANGE_UPPER_BOUND and also did you get chance to test this?

I have updated both daemonset and deployment but in this case they will pick the default value https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/1469/files#diff-5f5292175c0b29881ee742f0daf838980f771e03b22525cc574b4763b749a0ffR291 We have pushed this changes mapping a new image instead of repo: https://kubernetes-sigs.github.io/aws-efs-csi-driver/ in our dev cluster and working ok. Do you have in mind any other tests to be performed? Thank you in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avanish23 avanish23 avanish23 left review comments

@justinsb justinsb Awaiting requested review from justinsb

@mskanth972 mskanth972 Awaiting requested review from mskanth972

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cescribanohs @k8s-ci-robot @mskanth972 @avanish23