Skip to content

Commit

Permalink
Updates based on feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Christopher Hein <[email protected]>
  • Loading branch information
christopherhein committed Apr 10, 2018
1 parent 83c4444 commit 562cc3e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ systemctl restart kubelet.service
Finally, once the server is set up you'll want to authenticate!
You will still need a `kubeconfig` that has the public data about your cluster (cluster CA certificate, endpoint address).
The `users` section of your configuration, however, can be mostly blank:
The `users` section of your configuration, however, should include an exec section ([refer to the v1.10 docs](https://kubernetes.io/docs/admin/authentication/#client-go-credential-plugins))::
```yaml
# [...]
users:
Expand All @@ -112,7 +112,7 @@ Make sure you have the `heptio-authenticator-aws` binary installed.
You can install it with `go get -u -v github.com/heptio/authenticator/cmd/heptio-authenticator-aws`.

To authenticate, run `kubectl --kubeconfig /path/to/kubeconfig" [...]`.
kubectl will handle `exec`'ing the `heptio-authenticator-aws` binary with the supplied params in your kubeconfig which will generate a token and pass it to the apiserver.
kubectl will `exec` the `heptio-authenticator-aws` binary with the supplied params in your kubeconfig which will generate a token and pass it to the apiserver.
The token is valid for 15 minutes (the shortest value AWS permits) and can be reused multiple times.

You can also omit `-r ROLE_ARN` to sign the token with your existing credentials without assuming a dedicated role.
Expand Down
4 changes: 1 addition & 3 deletions cmd/heptio-authenticator-aws/token.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,7 @@ var tokenCmd = &cobra.Command{
fmt.Fprintf(os.Stderr, "could not get token: %v\n", err)
os.Exit(1)
}

enc := gen.FormatJSON(tok)
fmt.Println(enc)
fmt.Println(gen.FormatJSON(tok))
},
}

Expand Down

0 comments on commit 562cc3e

Please sign in to comment.